[ros-dev] Re: [ros-svn] [gvg] 13584: Fix ROUND_UP when N is a multiple of S. Proposed by unC0Rr.

[Hartmut Birr]

gvg at svn.reactos.com schrieb:

>Fix ROUND_UP when N is a multiple of S. Proposed by unC0Rr.
>
>
>
>Updated files:
>trunk/reactos/tools/mkhive/binhive.c
>
>_______________________________________________
>Ros-svn mailing list
>Ros-svn at reactos.com
>http://reactos.com:8080/mailman/listinfo/ros-svn
>
>
>  
>
Hi,

I don't like this implemention (and the old one) of ROUND_UP and 
ROUND_DOWN. I would prefer:

#define ROUND_UP(N,S)           (((N) + (S) -1) & ~((S) -1))
#define ROUND_DOWN(N,S)   ((N) & ~((S) - 1))

- Hartmut