[ros-dev] Re: [ros-svn] [weiden] 13138: implemented the ProcessSessionInformation information class

Hartmut Birr hartmut.birr at gmx.de
Thu Jan 20 01:55:52 CET 2005


weiden at svn.reactos.com schrieb:

>implemented the ProcessSessionInformation information class
>
>
>Updated files:
>trunk/reactos/ntoskrnl/ps/process.c
>
>_______________________________________________
>Ros-svn mailing list
>Ros-svn at reactos.com
>http://reactos.com:8080/mailman/listinfo/ros-svn
>
>
>  
>
Hi,

I think that some parts of your implementation are incorrect. The 
function must check for the location of the buffer and the previous 
mode. If the previous mode is user mode, the buffer must be located 
within the user address space. IMHO using of  MmCopyFrom/ToCaller is 
better than using an exception block. It is also true for your following 
commits.

- Hartmut



More information about the Ros-dev mailing list