[ros-dev] Console Csrss Handle Errors

[Casper Hornstrup]

> So, should we revert rbuild? It was a pretty big patch too. And I can
> name a couple of other ones... (let's not get started into to how many
> regressions rbuild caused :)

I gave you the opportunity to provide a list of revision numbers with
bugfixes for rbuild so we can see the real damages done by it and you
couldn't/didn't want to do that. It's impossible for me to counter your
"let's not get started into to how many regressions rbuild caused"
argument. I could never counter that strong argument.

However, if we had a list of bugfixes, we could calculate the number of
bugs per line of code in the rbuild patch. That is so much better since
we can actually use that to measure the success of the patch and to
improve the process, next time we develop such a big change.

> I cannot please you Casper, I'm sorry. First I make small changelogs,
> and you complain they are too small.

Not small. Very un-useful commit messages like "fix A". It would be very
useful for other developers to know what was actually changed.

> Then I make large ones, and you
> complain they are too big.

I don't know what you are referring to here.

> Then you tell me to use branches, I do, and
> you complain that it was too broad/large,
> and that I should split up
> patches and work on single features too.

Miscelanea branches, yes. Check. For more information on why they are bad look here:
http://reactos.com/wiki/index.php/Voting/Miscelanea_branches

> Now I spend two weeks on a
> patch which targets a single thing, and you compain again.

If it's a 10.000 line patch then I'm almost certain that only relation
there could be is that the code is involved in the CreateProcess control
path. Still no reason not to develop it incrementally IMO.

> Would it be
> better for you if I just left the project? Nothing sucks more then
> spending 2 weeks working on something (And YES it has and will still be
> reviewed by other devs) to be told "I don't want that'. I find that
> disappointing.
> 
> Best regards,
> Alex Ionescu

I'm sorry that you always think I'm "out to get you" when I complain
about the way we do things and you are involved. I can't change how you
feel - unless maybe I never will complain about things in which you are
involved.

It's not like you countered my preliminary arguments with great arguments
for developing such big patches in your local working copy. Why don't you
do that instead of bringing up a whole bunch of other unrelated issues?
Convince me (and others) that such big patches are good for the project.

Casper