[ros-dev] Re: [ros-diffs] [greatlrd] 16528: The return size calculation's of GetEnvironmentVariable string was wrong. Thx to <Bizzy_D> to find out cd %windir% did not work. Now it will

[magnus at itkonsult-olsen.com]

Hi
Harmurt
I have test the GetEnvironmentVariable it return number of chater.

Our  GetEnvironmentVariable  did count 1 char as zero and so on.
it did miss calcutaion by 1. instead geting 9 char it did only get 8 char.

This bug was expode by reactos cmd.
and we do not have any bug to getting env there, in windows. When you did
type echo %windir% it did print C:\ReactO before my bug fix. it should print
C:\ReactOS










Quoting Hartmut Birr <hartmut.birr at gmx.de>:

> Thomas Weidenmueller wrote:
>
> >Hartmut Birr wrote:
> >
> >
> >>Please revert your change.
> >>
> >>- Hartmut
> >>
> >>
> >>
> >
> >he already reverted the changes with his following commit after I told him.
> >
> >Best Regards,
> >
> >Thomas
> >
> >
> I do not mean the size mismatch. On success the function has to return
> the number of character not including the terminating null character.
> Currently, the function returns the number of character + 1.
>
> - Hartmut
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.com
> http://reactos.com:8080/mailman/listinfo/ros-dev
>