[ros-dev] DIB code generator

[Robert Köpferl]

You're confusing a generative approach with a generic approach.
It's a game with the meta layers of definition languages and compilers.

Handwriting several similar functions is generative (work) and one 
should think about stepping up one language-layer and let a special 
compiler (generator) write that. On the other hand one could make a 
general approach (many ifs).

Alex Ionescu wrote:
> Ge van Geldorp wrote:
> 
>> a lot of neat things
>>
> Well, I'm kind of confused. I always thought a code generator that 
> removes code duplication would *slow down* the code (Because it uses a 
> general approach) and *reduce size* (because it doesn't duplicate code 
> anymore). I am at a loss on why autogenerating code would make win32k 
> faster and 3 times larger? Isn't removing duplicate code going to make 
> it smaller?
> 
> Pardon my confusion...anyways, here's what I think:
> 
> A 3X size increase is not OK unless the speed improvement is phenomenal. 
> I'm talking at least 3X.
> 
> I also think we should leave win32k's dib functions alone for now and 
> simply try to minimize the duplication (but once again I don't see why 
> this increases size). It turns out that XP's actual fill rate is 48. 
> Ours is about 190, possibly 200 with a retail build. We are about 4 
> times faster. Our HLINE rate is even faster then the actual VMWare 
> Hardware Accelerated driver. In all other tests we beat XP. I think it's 
> time to congratulate everyone who helped on the optimizations, and move 
> on to fixing other things.... I do however, once again, agree that the 
> current win32k dib code is a mess and should be cleaned up...
> 
> Best regards,
> Alex Ionescu
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.com
> http://reactos.com:8080/mailman/listinfo/ros-dev
>