[ros-dev] Re: [ros-diffs] [ion] 13813: Fix queue item not being cleaned. Thank you Jim

Filip Navara xnavara at volny.cz
Fri Mar 4 07:20:58 CET 2005


ion at svn.reactos.com wrote:

>Fix queue item not being cleaned. Thank you Jim
>
>Modified: branches/alex_devel_branch/reactos/ntoskrnl/ke/queue.c
>  
>
> ------------------------------------------------------------------------
> *Modified: branches/alex_devel_branch/reactos/ntoskrnl/ke/queue.c*
>
>--- branches/alex_devel_branch/reactos/ntoskrnl/ke/queue.c	2005-03-04 04:10:03 UTC (rev 13812)
>+++ branches/alex_devel_branch/reactos/ntoskrnl/ke/queue.c	2005-03-04 04:15:46 UTC (rev 13813)
>@@ -207,7 +207,7 @@
>
>             
>             /* Remove the Entry */
>             RemoveEntryList(ListEntry);
>  
>
>-            Entry->Flink = NULL;
>  
>
>+            ListEntry->Flink = NULL;
>  
>
>             
>             /* Nothing to wait on */
>             break;
>  
>
This looks wrong. You should never clean list item this way, instead you 
should use "InitializeListHead(ListEntry);".

- Filip


More information about the Ros-dev mailing list