[ros-dev] Freeldr Question

[Casper Hornstrup]

If it isn't used, it should be removed to achieve minimalism. Subversion enables
us to get it back the day it need to be used.

I recently added a reference to Kevlin Henney's paper "Programmer's Dozen" in wiki.
He mentions minimalism amongst other issues. It's a good read on how to write
maintainable source code.

http://www.reactos.org/wiki/index.php/Development_Techniques/Programmer%27s_Dozen

Casper

> -----Original Message-----
> From: ros-dev-bounces at reactos.org [mailto:ros-dev-bounces at reactos.org] On Behalf Of Brian Palmer
> Sent: 17. november 2005 07:36
> To: 'ReactOS Development List'
> Subject: RE: [ros-dev] Freeldr Question
> 
> Alex,
> 
> I don't see the point of what you are trying to do. IIRC, all of
> FreeLoader's code is organized like the UI stuff - you just make generic
> calls and the abstraction code handles the details. It's kind of like C++
> objects, only not. Take, for instance, FreeLoader's file system code, it is
> the exact same way. You just call generic routines like open, close, read,
> and write, and the file system code checks what file system it is and
> redirects the function call accordingly.
> 
> Unless I don't understand what you are proposing, it sounds like you want to
> just lump all the UI code into one huge file. And I think that is a step
> backward from the current design. I'll admit that checking the UI type on
> every call and calling the GUI code or the TUI code isn't the most efficient
> way. And you could make it more efficient by setting up pointers to
> functions.
> 
> But unless you are talking about removing the GUI code altogether (it isn't
> used currently) you will still have to do the checks to see if DrawBox(),
> etc. needs to go to the TUI code or the GUI code. Now don't get me wrong, I
> don't think removing the GUI code is the right thing to do. It is a very
> good starting point for someone to make a graphical menu system for
> FreeLoader. It would be very cool someday to be able to set a company logo
> or something as background image in the boot screen.
> 
> I'd like to know more about what you are thinking...
> 
> -Brian