[ros-dev] RE: [ros-diffs] [ekohl] 18240: - Add german resources.

Hervé Poussineau hpoussin at reactos.com
Mon Oct 3 11:25:35 CEST 2005


 
> Modified: trunk/reactos/lib/cpl/hdwwiz/En.rc
>--- trunk/reactos/lib/cpl/hdwwiz/En.rc	2005-10-03 07:48:59 UTC (rev 18239)
> +++ trunk/reactos/lib/cpl/hdwwiz/En.rc	2005-10-03 09:14:57 UTC (rev
18240)
> @@ -1,4 +1,4 @@
> -LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US
> +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT
> 
> STRINGTABLE
> BEGIN

Why are you changing this?
According to http://support.microsoft.com/kb/169483/en-us , English
(Neutral) is not always searched by the resource loader, but English (US)
is. I don't know exactly what are the rules followed by ReactOS, but English
(US) allow the control panel to have correct resources on all Windows
versions.

> Modified: trunk/reactos/lib/cpl/hdwwiz/Fr.rc
> --- trunk/reactos/lib/cpl/hdwwiz/Fr.rc	2005-10-03 07:48:59 UTC (rev
18239)
> +++ trunk/reactos/lib/cpl/hdwwiz/Fr.rc	2005-10-03 09:14:57 UTC (rev
18240)
> @@ -1,4 +1,4 @@
>
> -LANGUAGE LANG_FRENCH, SUBLANG_NEUTRAL
> +LANGUAGE LANG_FRENCH, SUBLANG_DEFAULT
> 
> STRINGTABLE
> BEGIN

According to the same page, Primary Lang/Sub Lang is first searched,
followed by Primary Lang/Sublang_neutral. Primany Lang/Sublang_default is
not searched.
With your changes, French/Canadian and other would not have French
resources. Just try it on Windows, and you will see.

This change is also in contradiction with changes done in Wine some months
ago. (ChangeLog 0.2.7: "From Wine: changed SUBLANG_DEFAULT to
SUBLANG_NEUTRAL for LANG_SPANISH in all resources, so that Spanish locales
other than Spain also use Spanish resources")

Please revert these changes.

Hervé




More information about the Ros-dev mailing list