[ros-dev] very confused
rené Tournois <email@example.com> @mailhost.geldorp.nl
rené Tournois <firstname.lastname@example.org> at mailhost.geldorp.nl
Fri Feb 17 21:29:54 CET 2006
At 20:21 17/02/2006 +0100, you wrote:
>I think this only applies to the bootsector, wich has asm directly taken
>from disassemblies in it.
Ah. Then it should be the [Boot] sector. I see 5 files in there, with
asm statements. Only one could be a problem, that is named "longhorm.h".
52,000 Bytes long // 105 "_asm__". Outchhhh...
But did not another guy said that there was a possibility of complete
replacement? And, if i miss-undertood, or if not possible, would it
take one year for proof-reading 52,000 bytes of C Source?
>I think what Ged was talking about was disassemblies converted into C.
>And this can be found by looking for typical things of that kind of code:
>- Magical number inside C code. Normally constants are used or the
>numbers are commented or really obvios. But when you don't know why
>there's a constant 0x2342 then you don't really know how to call it. In
>disc.c there's a constant called PARTITION_MAGIC ;-)
>- excessive gotos: You would normally not use any gotos, but it can be
>hard to identify complex structures of for, if, while,... inside asm
>code, so you do it like it's done in asm: with gotos. It doesn't look
>good, but it works.
Ah! C simulating Assembly and hard coded unknown numbers...
OK, i see the problem better, with these points, as long as there is
really a _lot_ of Files with "goto"s inside, and i can imagine how
sorting all of these out, might be a boring task. But this was not,
at all, what was first said.
Thanks for the explanations. Betov.
More information about the Ros-dev