[ros-dev] RE: [ros-svn] [ekohl] 20496: - Service list entries use a
pointer to agroup list entry instead of the goup name.
Ge van Geldorp
gvg at reactos.org
Sun Jan 1 15:12:53 CET 2006
> From: ekohl at svn.reactos.org
>
> - Service list entries use a pointer to a group list entry
> instead of the goup name.
> - New group list entries are created in the
> unknown-group-list for services of unknown groups.
I'm seeing some crashes now because the lpGroup->lpService pointer is NULL.
Patch below seems to fix it, but I have no idea if it's the correct fix.
GvG
Index: subsys/system/services/rpcserver.c
===================================================================
--- subsys/system/services/rpcserver.c (revision 20508)
+++ subsys/system/services/rpcserver.c (working copy)
@@ -927,7 +927,7 @@
if (lpdwTagId != NULL)
{
- dwError = ScmAssignNewTag(lpService->lpGroup->lpGroupName,
+ dwError = ScmAssignNewTag(lpLoadOrderGroup,
&lpService->dwTag);
if (dwError != ERROR_SUCCESS)
goto done;
@@ -1161,7 +1161,7 @@
if (lpdwTagId != NULL)
{
- dwError = ScmAssignNewTag(lpService->lpGroup->lpGroupName,
+ dwError = ScmAssignNewTag(lpLoadOrderGroup,
&lpService->dwTag);
if (dwError != ERROR_SUCCESS)
goto done;
More information about the Ros-dev
mailing list