[ros-dev] tools/rbuild/backend/mingw/modulehandler.h

Reuben Perelman reub2000 at earthlink.net
Thu Jan 5 13:01:18 CET 2006


Somebody with write access should fix this simple little issue.

I also filed this bug on it:
http://www.reactos.org/bugzilla/show_bug.cgi?id=1240

Reuben Perelman wrote:

> Royce Mitchell III wrote:
>
>> Reuben Perelman wrote:
>>
>>> Looking at the file, I couldn't understand why MingwModuleHandler:: 
>>> was being used within the class of the same name, so I removed it 
>>> from before the definition of the functions. I'm guessing that it 
>>> was copied from the function definition outside of the class in a 
>>> .cpp file?
>>>
>> Good catch, sorry about that.
>
>
> Somebody with write access to svn should fix it.
>
>>
>>
>>> Also, I saw a lot of 'std::'. Why not use 'using namespace std;'?
>>
>>
>>
>> It's {very} bad practice to put using statements in header files - 
>> almost as bad as using goto :P
>>
>>
>>
>> _______________________________________________
>> Ros-dev mailing list
>> Ros-dev at reactos.org
>> http://www.reactos.org/mailman/listinfo/ros-dev
>>
>
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>



More information about the Ros-dev mailing list