[ros-dev] [ros-diffs] [ion] 23175: - Major formatting cleanup and optimizations to NtQueryInformationProcess so that it does not burn the eyes of anyone that might attempt to read it.
Royce Mitchell III
royce3 at ev1.net
Thu Jul 20 03:53:36 CEST 2006
ion at svn.reactos.org wrote:
>DstBuffer = (PWSTR)(DstPath + 1);
that looks pretty eye-burning itself... perhaps I'm just seeing things but,
1) you're incrementing a pointer without checking if it's null ( I
realize this might be safe if we can trust our caller ).
2) do we really want the address: DstPath + sizeof(PUNICODE_STRING)? I
realize this too might work, but do we want to assume that
sizeof(PUNICODE_STRING) == 2*sizeof(USHORT) ???
More information about the Ros-dev