[ros-dev] [ros-diffs] [hyperion] 25617: * _ReadBarrier, _WriteBarrier: defined as aliases for _ReadWriteBarrier. Alas * __emul, __emulu: fixed to specify instruction length suffix * __rdtsc: removed "__volatile__" attribute from the inline asm. Hyperion recommends you fix your goddamn code instead * __emul, __emulu, __rdtsc, __readmsr, __readpmc: return 64-bit values with the "=A" constraint instead of horrible kludge

Alex Ionescu ionucu at videotron.ca
Wed Jan 24 17:57:32 CET 2007


hyperion at svn.reactos.org wrote:
> Author: hyperion

>  * __rdtsc: removed "__volatile__" attribute from the inline asm. Hyperion recommends you fix your goddamn code instead

Congrats, you just broke ReactOS... did you even test this change, or
did you just assume that the "goddamn code sucks"? Even if it did, you
should've fixed it before breaking the OS.

-- 
Best regards,
Alex Ionescu
Project Lead, TinyKRNL
Kernel-Mode Software Design Engineer, ReactOS


More information about the Ros-dev mailing list