[ros-dev] [ros-diffs] [sginsberg] 35819: - CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined in winnt.h, so no need to define them in the NDK (the NDK includes winnt.h through windef.h, so this breaks build)

Stefan Ginsberg stefan__100__ at hotmail.com
Sun Aug 31 22:44:03 CEST 2008


"Umtypes is only included for user-mode, not for drivers."

ketypes.h imports umtypes.h --

#include <umtypes.h>
#ifndef NTOS_MODE_USER
#include <haltypes.h>
#include <potypes.h>
#include <ifssupp.h>
#endif

"Drivers do not import winnt.h"
they (still) do in ros as winddk.h imports winnt.h...

> Date: Sun, 31 Aug 2008 22:35:45 +0200
> From: ionucu at videotron.ca
> To: ros-dev at reactos.org
> Subject: Re: [ros-dev] [ros-diffs] [sginsberg] 35819: - CACHE_DESCRIPTOR and	PROCESSOR_CACHE_TYPE are public and defined in winnt.h,	so no need to define them in the NDK (the NDK includes winnt.h	through windef.h, so this breaks build)
> 
> Umtypes is only included for user-mode, not for drivers.
> 
> My e-mail was about drivers.
> 
> Drivers do not import winnt.h
> 
> Drivers import ntifs, wdm and ntddk.
> 
> Ntifs, wdm and ntddk are the headers that drivers import.
> 
> Not winnt.h.
> 
> My e-mail specifically listed those three headers and talked about drivers.
> 
> You guys come back saying "it's in winnt.h so it's okay!"
> 
> Are you blind, illiterate, or what?
> 
> Best regards,
> Alex Ionescu
> 
> 
> 
> On Sun, Aug 31, 2008 at 10:35 PM, Alex Ionescu <aionescu at gmail.com> wrote:
> > Umtypes is only included for user-mode, not for drivers.
> >
> > My e-mail was about drivers.
> >
> > Drivers do not import winnt.h
> >
> > Drivers import ntifs, wdm and ntddk.
> >
> > Ntifs, wdm and ntddk are the headers that drivers import.
> >
> > Not winnt.h.
> >
> > My e-mail specifically listed those three headers and talked about drivers.
> >
> > You guys come back saying "it's in winnt.h so it's okay!"
> >
> > Are you blind, illiterate, or what?
> >
> > Best regards,
> > Alex Ionescu
> >
> >
> >
> > 2008/8/31 Stefan Ginsberg <stefan__100__ at hotmail.com>:
> >> The NDK includes winnt.h through umtypes.h -> windef.h -> winnt.h (MS PSDK's
> >> windef.h includes winnt.h too, so I assumed this was correct).
> >> If this is wrong then how should it be done?
> >>
> >>> Date: Sun, 31 Aug 2008 01:00:18 +0200
> >>> From: ionucu at videotron.ca
> >>> To: ros-dev at reactos.org
> >>> Subject: Re: [ros-dev] [ros-diffs] [sginsberg] 35819: - CACHE_DESCRIPTOR
> >>> and PROCESSOR_CACHE_TYPE are public and defined in winnt.h, so no need to
> >>> define them in the NDK (the NDK includes winnt.h through windef.h, so this
> >>> breaks build)
> >>>
> >>> Please make sure that these types are available for DRIVERS as well --
> >>> otherwise, they belong in the NDK. (Check with WDK
> >>> wdm.h/ntddk.h/ntifs.h -- if it's not there, and drivers can access
> >>> pointers/structures of this type, it must be in the NDK).
> >>>
> >>> Also, the NDK does not include winnt.h -- at least it's not supposed
> >>> to, unless someone broke it.
> >>>
> >>> For the future, please make suer to review NDK changes with me, since
> >>> I'm still its owner.
> >>>
> >>> Best regards,
> >>> Alex Ionescu
> >>>
> >>>
> >>>
> >>> On Sat, Aug 30, 2008 at 11:34 PM, <sginsberg at svn.reactos.org> wrote:
> >>> > Author: sginsberg
> >>> > Date: Sat Aug 30 16:34:56 2008
> >>> > New Revision: 35819
> >>> >
> >>> > URL: http://svn.reactos.org/svn/reactos?rev=35819&view=rev
> >>> > Log:
> >>> > - CACHE_DESCRIPTOR and PROCESSOR_CACHE_TYPE are public and defined in
> >>> > winnt.h, so no need to define them in the NDK (the NDK includes winnt.h
> >>> > through windef.h, so this breaks build)
> >>> >
> >>> > Modified:
> >>> > trunk/reactos/include/ndk/ketypes.h
> >>> >
> >>> > Modified: trunk/reactos/include/ndk/ketypes.h
> >>> > URL:
> >>> > http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/ketypes.h?rev=35819&r1=35818&r2=35819&view=diff
> >>> >
> >>> > ==============================================================================
> >>> > --- trunk/reactos/include/ndk/ketypes.h [iso-8859-1] (original)
> >>> > +++ trunk/reactos/include/ndk/ketypes.h [iso-8859-1] Sat Aug 30 16:34:56
> >>> > 2008
> >>> > @@ -542,17 +542,6 @@
> >>> > } KAPC_ENVIRONMENT;
> >>> >
> >>> > //
> >>> > -// CPU Cache Types
> >>> > -//
> >>> > -typedef enum _PROCESSOR_CACHE_TYPE
> >>> > -{
> >>> > - CacheUnified,
> >>> > - CacheInstruction,
> >>> > - CacheData,
> >>> > - CacheTrace,
> >>> > -} PROCESSOR_CACHE_TYPE;
> >>> > -
> >>> > -//
> >>> > // PRCB DPC Data
> >>> > //
> >>> > typedef struct _KDPC_DATA
> >>> > @@ -571,18 +560,6 @@
> >>> > struct _GENERAL_LOOKASIDE *P;
> >>> > struct _GENERAL_LOOKASIDE *L;
> >>> > } PP_LOOKASIDE_LIST, *PPP_LOOKASIDE_LIST;
> >>> > -
> >>> > -//
> >>> > -// CPU Cache Descriptor
> >>> > -//
> >>> > -typedef struct _CACHE_DESCRIPTOR
> >>> > -{
> >>> > - UCHAR Level;
> >>> > - UCHAR Associativity;
> >>> > - USHORT LineSize;
> >>> > - ULONG Size;
> >>> > - PROCESSOR_CACHE_TYPE Type;
> >>> > -} CACHE_DESCRIPTOR, *PCACHE_DESCRIPTOR;
> >>> >
> >>> > //
> >>> > // Architectural Types
> >>> >
> >>> >
> >>> _______________________________________________
> >>> Ros-dev mailing list
> >>> Ros-dev at reactos.org
> >>> http://www.reactos.org/mailman/listinfo/ros-dev
> >>
> >> ________________________________
> >> Connect to the next generation of MSN Messenger  Get it now!
> >> _______________________________________________
> >> Ros-dev mailing list
> >> Ros-dev at reactos.org
> >> http://www.reactos.org/mailman/listinfo/ros-dev
> >>
> >>
> >
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev

_________________________________________________________________
Explore the seven wonders of the world
http://search.msn.com/results.aspx?q=7+wonders+world&mkt=en-US&form=QBRE
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.reactos.org/pipermail/ros-dev/attachments/20080831/dd5dd7e5/attachment.html 


More information about the Ros-dev mailing list