[ros-dev] [ros-diffs] [tkreuzer] 33856: - fix mem leak when failing to create an extpen with penstyles

Timo Kreuzer timo.kreuzer at web.de
Wed Jun 4 21:47:39 CEST 2008


Not completely, there's still one case left. line 73: if (!PenObject) 
{... return 0;}
I'd say it's better practice to have the caller delete the memory. The 
double free can be avoided, by
"PenObject->pStyle = NULL;" before cleanup.

James Tabor schrieb:
> Hi,
> I looked at it again,,, I think I fixed the leak and the crash in 33857,
> Sorry,
> James
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>
>   



More information about the Ros-dev mailing list