[ros-dev] [ros-diffs] [dchapyshev] 37396: - Implement BindIoCompletionCallback, ReadFileScatter, WriteFileGather (based on Wine) - Move DnsHostnameToComputerNameA/W to computername.c
aleksey at reactos.org
Mon Nov 17 14:40:06 CET 2008
On Nov 17, 2008, at 4:20 PM, gedmurphy wrote:
> Steven has repeatedly asked for credit, and I quote:
> " Please add the appropriate copyright headers to the source file
> stating the original author when implementing code based on third
> party sources."
There is one concern about it: how to find a proper author for a
specific function he is copying? We can look at the top of the file,
but there are a number of people listed there, possibly responsible
for different parts of the file. Should he review all Wine commits
and pick an author of the patch? What if the specific function was
patched later by a few authors?
> Is there a reason for not doing it this time?
> Secondly, why are things being implemented in stubs?
There is same stuff in gdi32 stub.c having a few implemented
functions, iirc. Not very good decision, but as long as people
responsible remember about this.. and keep moving it to appropriate
places, I don't mind.
More information about the Ros-dev