[ros-dev] [ros-diffs] [dgorbachev] 39422: Fix bug #4129 in CmpGetNameControlBlock().

Timo Kreuzer timo.kreuzer at web.de
Mon Feb 16 20:13:38 CET 2009


I agree with Dmitry on that matter. The brackets are bad. They only hide
possible bugs. I don't see any advantage. They don't add anything for
the compiler nor do they add anything to readability. IMO it's easier to
read with less braces.

Timo

Aleksey Bragin schrieb:
> Good, let's discuss it developers-wide then, and add a result into  
> the (to become official) Coding Style Guidelines for kernel-mode code.
> The only thing I'm bothered with is to keep the style consistent  
> across kernel (and drivers, where possible). And right now bracing  
> arguments of && and || prevails.
>
> I'm eager to listen to other dev's opinion on that topic. You just  
> showed one disadvantage of such method. Are there any advantages?
>
>
> WBR,
> Aleksey.
>
> On Feb 16, 2009, at 8:47 PM, Dmitry Gorbachev wrote:
>
>   
>>> No, it's just a matter of coding style used in the kernel.
>>>       
>> What is a logical basis for adopting this particular rule?  
>> Sometimes it is
>> not just a matter of preference.
>>
>> These parentheses are unnecessary for humans, and if they are not  
>> needed for
>> compilers or some other tools, they are bad! Without them, the bug  
>> could be
>> noticed earlier.
>>
>> Cheers,
>> Dmitry
>>     
>
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.reactos.org/pipermail/ros-dev/attachments/20090216/212b86e3/attachment-0001.html 


More information about the Ros-dev mailing list