[ros-dev] [ros-diffs] [jimtabor] 38518: - Removed SEH abuse and add notes for the hook code, in NtUserDefSetText. - Update NtUserCallHwndLock subfunctions.

James Tabor jimtabor.rosdev at gmail.com
Sat Jan 3 19:58:47 CET 2009


So, ProbeForReadUnicodeString is crippled and only copies the structure data...
I see,,,, I must add that we are using the wrong structure too.
LARGE_UNICODE_STRING is passed not that other one.


On Sat, Jan 3, 2009 at 10:18 AM, Thomas Bluemel <thomas at reactsoft.com> wrote:
> ProbeForReadUnicodeString should at least probe the buffers, otherwise
> the function is pointless. I believe at one point it did, and it was
> probably removed for some strange reason. The reason it copies the
> UNICODE_STRING is so that the pointers can't be modified anymore.
> Thomas
> Timo Kreuzer wrote:
>> SEH is still needed. SafeText doesn't really deserve it's name, as it's
>> only a safe copy of the UNICODE_STRING structure  returned by
>> ProbeForReadUnicodeString(), but with the still unsafe string buffer.
>> Also the Buffer was never probed (ProbeForReadUnicodeString only checks
>> the UNICODE_STRING and copies it)
>> IMO the function is dangerous, as it implies that the Buffer was probed,
>> too.
>> Timo


More information about the Ros-dev mailing list