[ros-dev] [ros-diffs] [cgutman] 46237: - Add a hack to disable ACPI if VMware is detected - This hack circumvents the main blocker that prevents enabling ACPI in trunk

[Olaf Siejka]

ACPI doesnt work with vbox guest additions, which is a trunk blocker as
well, IMO. Patch provided by aicom fixes the crash but introduces/leaves the
following random crash:

err:(dll\win32\user32\windows\window.c:281) CreateWindowExA
RegisterSystemControls
Boot took 33447053948 cycles!
Interrupts: 2302 System Calls: 10824 Context Switches: 1389

*** Fatal System Error: 0x0000007f
(0x00000008,0x00000000,0x00000000,0x00000000)

Entered debugger on embedded INT3 at 0x0008:0x808dff98.
kdb:> bt
Eip:
<ntoskrnl.exe:dff99 (lib\rtl\i386\debug_asm.S:42
(RtlpBreakWithStatusInstruction))>
Frames:
<ntoskrnl.exe:a44f (ntoskrnl/ke/bug.c:1110 (KeBugCheckWithTf at 24))>
<ntoskrnl.exe:269d (ntoskrnl/ke/i386/exp.c:92 (@KiRecordDr7 at 8))>
<ntoskrnl.exe:5f05 (ntoskrnl/ke/i386/traphdlr.c:522 (@KiTrap05Handler at 4))>
<00000000>

2010/3/17 Aleksey Bragin <aleksey at reactos.org>

> Very nasty.
>
> --------------------------------------------------
> From: <cgutman at svn.reactos.org>
> Sent: Wednesday, March 17, 2010 8:02 AM
> To: <ros-diffs at reactos.org>
> Subject: [ros-diffs] [cgutman] 46237: - Add a hack to disable ACPI if
> VMware is detected - This hack circumvents the main blocker that prevents
> enabling ACPI in trunk
>
>  Author: cgutman
>> Date: Wed Mar 17 06:02:06 2010
>> New Revision: 46237
>>
>> URL: http://svn.reactos.org/svn/reactos?rev=46237&view=rev
>> Log:
>> - Add a hack to disable ACPI if VMware is detected
>> - This hack circumvents the main blocker that prevents enabling ACPI in
>> trunk
>>
>> Modified:
>>   trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c
>>
>> Modified: trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c
>> URL:
>> http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c?rev=46237&r1=46236&r2=46237&view=diff
>>
>> ==============================================================================
>> --- trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c [iso-8859-1]
>> (original)
>> +++ trunk/reactos/drivers/bus/acpi/acpica/tables/tbutils.c [iso-8859-1]
>> Wed Mar 17 06:02:06 2010
>> @@ -592,6 +592,7 @@
>>    UINT32                  Length;
>>    UINT8                   *TableEntry;
>>    ACPI_STATUS             Status;
>> +    ACPI_TABLE_HEADER       LocalHeader;
>>
>>
>>    ACPI_FUNCTION_TRACE (TbParseRootTable);
>> @@ -645,6 +646,14 @@
>>    }
>>
>>    AcpiTbPrintTableHeader (Address, Table);
>> +
>> +    AcpiTbCleanupTableHeader (&LocalHeader, Table);
>> +    if (strstr(LocalHeader.AslCompilerId, "VMW"))
>> +    {
>> +        ACPI_ERROR ((AE_INFO, "VMware detected; ACPI has been
>> disabled\n"));
>> +        AcpiOsUnmapMemory (Table, sizeof (ACPI_TABLE_HEADER));
>> +        return_ACPI_STATUS (AE_ERROR);
>> +    }
>>
>>    /* Get the length of the full table, verify length and map entire table
>> */
>>
>>
>>
>>
> _______________________________________________
> Ros-dev mailing list
> Ros-dev at reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.reactos.org/pipermail/ros-dev/attachments/20100317/bf70ebe8/attachment.htm>