[ros-dev] [ros-diffs] [mjmartin] 47393: [win32k] - The timer is created usingUserCreateObject. It may be a good idea to save the handle in the timer object so that it can be deleted later. - Dereference the object before attempting to delete it.

[Michael Martin]

Yes EnterUserExclusive is used alot elsewhere in win32k and we dont really need to use it with timers, so its inefficient.
I'm going to change this so that timers use thier own lock.

mike
Date: Sun, 30 May 2010 23:48:11 +0100
From: gedmurphy at gmail.com
To: ros-dev at reactos.org
Subject: Re: [ros-dev] [ros-diffs] [mjmartin] 47393: [win32k] - The timer is	created usingUserCreateObject. It may be a good idea to save	the handle in the timer object so that it can be deleted	later. - Dereference the object before attempting to delete it.

I've spoken to Mike about this, apparently the lock is held much higher in the call chain (EnterUserExclusive), which isn't obvious in the patch.
Sounds like a pretty inefficient lock though.

On 30 May 2010 23:37, James Tabor <jimtabor.rosdev at gmail.com> wrote:

Locks?




 		 	   		  
_________________________________________________________________
The New Busy think 9 to 5 is a cute idea. Combine multiple calendars with Hotmail. 
http://www.windowslive.com/campaign/thenewbusy?tile=multicalendar&ocid=PID28326::T:WLMTAGL:ON:WL:en-US:WM_HMP:042010_5
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.reactos.org/pipermail/ros-dev/attachments/20100530/9b30157c/attachment.htm>