[ros-dev] [ros-diffs] [ekohl] 53469: [WIDL] Revert parts of r53171: Remove the -Oif flag for WIDL because the NT4 stub code generated by the current WIDL is heavily broken with respect to the range attribute and others....

[Jérôme Gardou]

HI Eric!

I'm not sure about what you mean for range attribute, but I notice that
typedef [context_handle] PVOID my_handle;
makes widl thinks that any value of the my_handle type is passed by 
pointer, whereas midl considers it is passed by value.

Could you be more precise about "range attributes and others?" please.

Regards.
Jérôme.

Le 27/08/2011 18:24, ekohl at svn.reactos.org a écrit :
> Author: ekohl
> Date: Sat Aug 27 16:24:40 2011
> New Revision: 53469
>
> URL: http://svn.reactos.org/svn/reactos?rev=53469&view=rev
> Log:
> [WIDL]
> Revert parts of r53171:
> Remove the -Oif flag for WIDL because the NT4 stub code generated by the current WIDL is heavily broken with respect to the range attribute and others. Please enable the -Oif feature only after these bugs are fixed in WIDL!
>
> Modified:
>      trunk/reactos/cmake/idl-support.cmake
>      trunk/reactos/tools/rbuild/backend/mingw/rules.mak
>
> Modified: trunk/reactos/cmake/idl-support.cmake
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/idl-support.cmake?rev=53469&r1=53468&r2=53469&view=diff
> ==============================================================================
> --- trunk/reactos/cmake/idl-support.cmake [iso-8859-1] (original)
> +++ trunk/reactos/cmake/idl-support.cmake [iso-8859-1] Sat Aug 27 16:24:40 2011
> @@ -22,8 +22,8 @@
>       set(IDL_HEADER_ARG -h -o) #.h
>       set(IDL_HEADER_ARG2 -h -H) #.h
>       set(IDL_TYPELIB_ARG -t -o) #.tlb
> -    set(IDL_SERVER_ARG -Oif -s -o) #.c for server library
> -    set(IDL_CLIENT_ARG -Oif -c -o) #.c for stub client library
> +    set(IDL_SERVER_ARG -s -o) #.c for server library
> +    set(IDL_CLIENT_ARG -c -o) #.c for stub client library
>       set(IDL_PROXY_ARG -p -o)
>       set(IDL_INTERFACE_ARG -u -o)
>       if(ARCH MATCHES i386)
> @@ -169,6 +169,6 @@
>           list(APPEND IID_SOURCES ${NAME}_i.c)
>       endforeach()
>       add_library(${TARGET} ${IID_SOURCES})
> -	add_dependencies(${TARGET} psdk)
> +    add_dependencies(${TARGET} psdk)
>       set_target_properties(${TARGET} PROPERTIES EXCLUDE_FROM_ALL TRUE)
>   endfunction()
>
> Modified: trunk/reactos/tools/rbuild/backend/mingw/rules.mak
> URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/backend/mingw/rules.mak?rev=53469&r1=53468&r2=53469&view=diff
> ==============================================================================
> --- trunk/reactos/tools/rbuild/backend/mingw/rules.mak [iso-8859-1] (original)
> +++ trunk/reactos/tools/rbuild/backend/mingw/rules.mak [iso-8859-1] Sat Aug 27 16:24:40 2011
> @@ -264,7 +264,7 @@
>
>   ${call RBUILD_intermediate_path_noext,$(2)}_c: $(2) $(3) $$(widl_TARGET) | ${call RBUILD_intermediate_dir,$(2)}
>   	$$(ECHO_WIDL)
> -	$$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -Oif -h -H ${call RBUILD_intermediate_path_noext,$(2)}_c.h -c -C ${call RBUILD_intermediate_path_noext,$(2)}_c.c $(2)
> +	$$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -h -H ${call RBUILD_intermediate_path_noext,$(2)}_c.h -c -C ${call RBUILD_intermediate_path_noext,$(2)}_c.c $(2)
>   	$${checkpoint} $$@>$(NUL)
>
>   ${call RBUILD_CC,$(1),${call RBUILD_intermediate_path_noext,$(2)}_c.c,,,${call RBUILD_intermediate_path_noext,$(2)}_c.o}
> @@ -280,7 +280,7 @@
>
>   ${call RBUILD_intermediate_path_noext,$(2)}_s: $(2) $(3) $$(widl_TARGET) | ${call RBUILD_intermediate_dir,$(2)}
>   	$$(ECHO_WIDL)
> -	$$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -Oif -h -H ${call RBUILD_intermediate_path_noext,$(2)}_s.h -s -S ${call RBUILD_intermediate_path_noext,$(2)}_s.c $(2)
> +	$$(Q)$$(widl_TARGET) ${call RBUILD_midlflags,$(1),$(4),-I${call RBUILD_dir,$(2)}} -h -H ${call RBUILD_intermediate_path_noext,$(2)}_s.h -s -S ${call RBUILD_intermediate_path_noext,$(2)}_s.c $(2)
>   	$${checkpoint} $$@>$(NUL)
>
>   ${call RBUILD_CC,$(1),${call RBUILD_intermediate_path_noext,$(2)}_s.c,,,${call RBUILD_intermediate_path_noext,$(2)}_s.o}
>
>