brianp at sginet.com
Mon Jun 20 03:44:20 UTC 2011
Again, please cite your sources Alex...
I'm pretty sure you were the one who suggested this vtable system in the
first place, for at least some parts of the FreeLoader code anyways, because
I didn't write it. But it does have some usefulness in places such as the UI
code where, depending on the platform, it does take a different code path,
and multiple code paths are valid options to be compiled in and parsed at
runtime depending on the .ini file.
In any case, please stop adding useless comments like this unless you intend
to bring up the original points of objection along with it. A simple "I
agree with the proposed change" would have sufficed here, and I'm tired of
going the rounds with you over conversations that never took place.
From: ros-dev-bounces at reactos.org [mailto:ros-dev-bounces at reactos.org] On
Behalf Of Alex Ionescu
Sent: Sunday, June 19, 2011 7:27 AM
To: ReactOS Development List
Subject: Re: [ros-dev] freeldr
I wrote this exact same request 3 years ago and Brian said no :)
On Sun, Jun 19, 2011 at 9:02 AM, Timo Kreuzer <timo.kreuzer at web.de> wrote:
> I'd like to change the Vtbl based architecture of freeldr into a normal
> function call system.
> Currently we have stuff like
> #define MachHwDetect() MachVtbl.HwDetect()
> MachVtbl.HwDetect = PcHwDetect;
> This is IHO simply useless, since these functions don't change. I suggest
> simply renaming PcHwDetect to MachHwDetect and do that will all of those
> get rid of the MachVtbl.
> Any objections?
> Ros-dev mailing list
> Ros-dev at reactos.org
Ros-dev mailing list
Ros-dev at reactos.org
More information about the Ros-dev