[ros-dev] [ros-diffs] [gadamopoulos] 51115: [ntoskrnl] - Implement calling OkayToCloseProcedure callouts to win32k for desktop and window station objects - Fix a bug that caused ObpCloseHandle to return success even whe...

[Michael Martin]

Uhhh No.
I am sure everyone appreciates any constructive comments pointing out bugs or flaws. Especially from someone like Alex that knows his stuff.
But if you come across as cocky and demeaning while doing this, your bound to get some disrespect, whether your name is on cover of Windows Internals or not.
Alex's email came across to me this way.

Something such as
"This code suffers from a security bug which I talked about at Blackhat 2 or 3 years ago (Fixed since Vista).
Also the code ignores the exported PsSetProcessWindowStation API and relevant EPROCESS field."
would have been totally professional and totally appropriate.

Mike

Date: Wed, 23 Mar 2011 00:22:00 -0400
From: waxdragon at gmail.com
To: ros-dev at reactos.org
Subject: Re: [ros-dev] [ros-diffs] [gadamopoulos] 51115: [ntoskrnl] - Implement calling OkayToCloseProcedure callouts to win32k for desktop and window station objects - Fix a bug that caused ObpCloseHandle to return success even whe...

Unbelievable!  We should be happy that Alex even commented on this commit to point out a flaw.  Spend some time looking in to what he said, and less time disrespecting a man with his name on the cover of Windows Internals.

Waxy

On Tue, Mar 22, 2011 at 7:35 PM, Timo Kreuzer <timo.kreuzer at web.de> wrote:

Am 22.03.2011 23:17, gab Alex Ionescu folgendes von sich:


bla bla bla bla bla bla bla bla



--

Best regards,

Alex Ionescu






-- 
<+encoded> if you square a unicorn do you get a real animal?



_______________________________________________
Ros-dev mailing list
Ros-dev at reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.reactos.org/pipermail/ros-dev/attachments/20110323/6426909d/attachment-0001.htm>