[ros-dev] Setupapi & VBox additions
thfabba at gmx.de
Tue Oct 4 07:20:53 UTC 2011
I've been looking at VirtualBox 4.1.x guest additions, which don't install
in ROS  and came up with a patch  that seems to fix them.
While patchbot says this is okay  (and the last hunk even fixes a few
setupapi tests), I am very unsure about the SP_COPY_NOOVERWRITE part.
The correct solution might instead be to handle SetupCopyOEMInf returning
ERROR_FILE_EXISTS or I might be "fixing" something in the completely
It would be great if someone with some insight into setupapi
(Eric? Hervé? ;]) could review this and give some pointers.
- The first hunk isn't really required, but I guess it shouldn't break
anything, and seems to find what it's looking for this way.
- The second hunk is in the code path used by VBox guest additions setup.
It is apparently called with an already-existing inf file, but I have
no idea why. :|
- The third hunk is a trivial bug that our CreateService just didn't
complain about before r53872/r53886
More information about the Ros-dev