[ros-dev] [ros-diffs] [tfaber] 53688: [NTOSKRNL][RTL][DOC] - Fix incorrect loop boundaries in the ARM version of MmCreateProcessAddressSpace. Spotted by Vincenzo Cotugno and cppcheck - Correct outdated wineimport.cmd UR...
ionucu at videotron.ca
Sun Sep 11 12:45:23 UTC 2011
Sorry but these kinds of fixes are not "readability fixes", in fact they
make things more obtuse.
(*MdlPages << PAGE_SHIFT)) could be interpreted as
*(MdlPages << PAGE_SHIFT).
((*MdlPages) << PAGE_SHIFT)
Makes it clear what is happening.
In general, all operations affecting the contents of a *dereference should
be in parens.
On Sun, Sep 11, 2011 at 7:47 AM, <tfaber at svn.reactos.org> wrote:
> - ((*MdlPages) << PAGE_SHIFT));
> + (*MdlPages << PAGE_SHIFT));
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Ros-dev