[ros-dev] [ros-diffs] [fireball] 54833: [NTOS] - Cast to actually returned types not just PVOID.

Aleksey Bragin aleksey at reactos.org
Sat Jan 7 09:11:25 UTC 2012


Sorry, that change slipped through with two others which make a bit more 
sense.

Feel free to revert when revisiting the file with some other change next 
time.

WBR,
Aleksey.


On 07.01.2012 12:38, Timo Kreuzer wrote:
> Hi,
>
> what's the point of this change? IMO it's just ugly when we start 
> casting from PVOID everywhere.
>
> Timo
>
> Am 04.01.2012 13:22, schrieb fireball at svn.reactos.org:
>> Author: fireball
>> Date: Wed Jan  4 12:22:38 2012
>> New Revision: 54833
>>
>> URL: http://svn.reactos.org/svn/reactos?rev=54833&view=rev
>> Log:
>> [NTOS]
>> - Cast to actually returned types not just PVOID.
>>
>> Modified:
>>      trunk/reactos/ntoskrnl/include/internal/lpc_x.h
>>
>> Modified: trunk/reactos/ntoskrnl/include/internal/lpc_x.h
>> URL: 
>> http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/lpc_x.h?rev=54833&r1=54832&r2=54833&view=diff
>> ============================================================================== 
>>
>> --- trunk/reactos/ntoskrnl/include/internal/lpc_x.h [iso-8859-1] 
>> (original)
>> +++ trunk/reactos/ntoskrnl/include/internal/lpc_x.h [iso-8859-1] Wed 
>> Jan  4 12:22:38 2012
>> @@ -103,7 +103,7 @@
>>
>>       /* Allocate a message from the port zone while holding the lock */
>>       KeAcquireGuardedMutex(&LpcpLock);
>> -    Message = ExAllocateFromPagedLookasideList(&LpcpMessagesLookaside);
>> +    Message = 
>> (PLPCP_MESSAGE)ExAllocateFromPagedLookasideList(&LpcpMessagesLookaside);
>>       if (!Message)
>>
>




More information about the Ros-dev mailing list