[ros-diffs] [ion] 23256: - Temporarly disable screensaver code. Sorry greatlord but you're creating 150 realtime threads per minute and killing the system with the code. Please fix it. - Fix some incorrect tracing macro usage and make it add the current line. - Re-organize I/O bugs per priority.

ion at svn.reactos.org ion at svn.reactos.org
Sun Jul 23 22:12:46 CEST 2006


Author: ion
Date: Mon Jul 24 00:12:45 2006
New Revision: 23256

URL: http://svn.reactos.org/svn/reactos?rev=23256&view=rev
Log:
- Temporarly disable screensaver code. Sorry greatlord but you're creating 150 realtime threads per minute and killing the system with the code. Please fix it.
- Fix some incorrect tracing macro usage and make it add the current line.
- Re-organize I/O bugs per priority.

Modified:
    trunk/reactos/ntoskrnl/KrnlFun.c
    trunk/reactos/ntoskrnl/include/internal/ps.h
    trunk/reactos/ntoskrnl/ps/process.c
    trunk/reactos/subsystems/win32/win32k/ntuser/input.c

Modified: trunk/reactos/ntoskrnl/KrnlFun.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/KrnlFun.c?rev=23256&r1=23255&r2=23256&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/KrnlFun.c (original)
+++ trunk/reactos/ntoskrnl/KrnlFun.c Mon Jul 24 00:12:45 2006
@@ -9,20 +9,19 @@
 //              Failure to respect this will *ACHIEVE NOTHING*.
 //
 // Io:
-//  - Add support for Fast Dispatch I/O.
-//  - Verify ShareAccess APIs, XP added some new semantics.
+//  - Fix double-reference in IopCreateFile.
+//  - Add SEH to some places where it's missing (MDLs, etc) (iofunc).
+//  - Add a generic Cleanup/Exception Routine (iofunc).
+//  - See why queueing IRPs and cancelling them causes crashes
+//  - Add another parameter to IopCleanupFailedIrp.
 //  - Add Access Checks in IopParseDevice.
 //  - Add validation checks in IoCreateFile.
-//  - Fix double-reference in IopCreateFile.
+//  - Add probe/alignment checks for Query/Set routines.
+//  - Add tracing to iofunc.c
 //  - Add tracing to file.c
-//  - See why queueing IRPs and cancelling them causes crashes
-//  - Add SEH to some places where it's missing (MDLs, etc) (iofunc).
-//  - Add a generic Cleanup/Exception Routine (iofunc).
-//  - Add probe/alignment checks for Query/Set routines.
-//  - Add another parameter to IopCleanupFailedIrp.
+//  - Add support for some fast-paths when querying/setting data.
+//  - Verify ShareAccess APIs, XP added some new semantics.
 //  - Add support for Fast Dispatch I/O.
-//  - Add support for some fast-paths when querying/setting data.
-//  - Add tracing to iofunc.c
 //
 // Ps:
 //  - Figure out why processes don't die.

Modified: trunk/reactos/ntoskrnl/include/internal/ps.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/ps.h?rev=23256&r1=23255&r2=23256&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/include/internal/ps.h (original)
+++ trunk/reactos/ntoskrnl/include/internal/ps.h Mon Jul 24 00:12:45 2006
@@ -49,7 +49,9 @@
 #endif
 #define PSREFTRACE(x)                                       \
     PSTRACE(PS_REF_DEBUG,                                   \
-            "Pointer Count: %lx\n",                         \
+            "Pointer Count [%p] @%lx: %lx\n",               \
+            x,                                              \
+            __LINE__,                                       \
             OBJECT_TO_OBJECT_HEADER(x)->PointerCount);
 #else
 #define PSTRACE(x, ...) DPRINT(__VA_ARGS__);

Modified: trunk/reactos/ntoskrnl/ps/process.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/process.c?rev=23256&r1=23255&r2=23256&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/ps/process.c (original)
+++ trunk/reactos/ntoskrnl/ps/process.c Mon Jul 24 00:12:45 2006
@@ -400,7 +400,7 @@
                                            (PVOID*)&Parent,
                                            NULL);
         if (!NT_SUCCESS(Status)) return Status;
-        PSREFTRACE(ParentProcess);
+        PSREFTRACE(Parent);
 
         /* If this process should be in a job but the parent isn't */
         if ((InJob) && (!Parent->Job))
@@ -1426,7 +1426,7 @@
         /* Dereference the Process */
         ObDereferenceObject(Process);
         PSREFTRACE(Process);
-        PSREFTRACE(Thread);
+        if (Thread) PSREFTRACE(Thread);
     }
     else
     {

Modified: trunk/reactos/subsystems/win32/win32k/ntuser/input.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ntuser/input.c?rev=23256&r1=23255&r2=23256&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntuser/input.c (original)
+++ trunk/reactos/subsystems/win32/win32k/ntuser/input.c Mon Jul 24 00:12:45 2006
@@ -169,7 +169,7 @@
    NTSTATUS Status;
    BOOL FirstTime = TRUE;
 
-
+    return;
    KeSetPriorityThread(&PsGetCurrentThread()->Tcb,
                        LOW_REALTIME_PRIORITY + 3);
 




More information about the Ros-diffs mailing list