[ros-diffs] [fireball] 21931: [AUDIT] ntoskrnl/dbgk (according to
functions_list.txt in audited branch comments by Alex Ionescu,
and comments by me) - debug.c: Clean/trivial implementation based on the
object's structure. I merely create it and then initailize all its members.
Other functions are stubs - dbgkutil.c: Code is #if0'ed,
and doesn't belong to Alex Ionescu. Author is unknown. - Unified /
prettified formatting, STDCALL -> NTAPI
fireball at svn.reactos.org
fireball at svn.reactos.org
Thu May 18 14:16:53 CEST 2006
- Previous message: [ros-diffs] [fireball] 21930: [AUDIT] ntoskrnl/ex (according to
functions_list.txt in audited branch comments by Alex Ionescu,
and uuid.c comments by me) - dbgctrl.c: Modified the function slightly for
compatibility with some keys,
still has nothing to do with Windows' - lookas.c: File is clean. I merely
rewrote existing versions based on a GPLed IBM driver I found on google,
OSR documentation and some DDK sample code. The implementation is trivial
and only calls caller-defined functions which are the ones doing the work.
- uuid.c: Added programmers, unified formatting,
STDCALL->NTAPI change. Code doesn't look suspicious,
plus stubbed functions - win32k.c: Alex Ionescu only changed the functions
to call Win32K instead of having the code in ntoskrnl. It was a cut/paste
job. Aleksey Bragin: The code looks very trivial and straightforward,
certainly it's written based on clean sources of information - zone.c: Based
on David Welch's code, which Alex Ionescu merely cleaned up,
using clean development. He's not even sure if the Zone functions are still
in Windows.
- Next message: [ros-diffs] [fireball] 21932: [AUDIT] ntoskrnl/ex/error.c - Alex
Ionescu states the
implementations are clean: I just re-orgznied the *harderror functions. The
SEH filter is a trivial/well-known return of a single value,
and __purecall is a stub.
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Author: fireball
Date: Thu May 18 16:16:53 2006
New Revision: 21931
URL: http://svn.reactos.ru/svn/reactos?rev=21931&view=rev
Log:
[AUDIT]
ntoskrnl/dbgk
(according to functions_list.txt in audited branch comments by Alex Ionescu, and comments by me)
- debug.c: Clean/trivial implementation based on the object's structure. I merely create it and then initailize all its members. Other functions are stubs
- dbgkutil.c: Code is #if0'ed, and doesn't belong to Alex Ionescu. Author is unknown.
- Unified / prettified formatting, STDCALL -> NTAPI
Modified:
trunk/reactos/ntoskrnl/dbgk/dbgkutil.c (contents, props changed)
trunk/reactos/ntoskrnl/dbgk/debug.c (contents, props changed)
Modified: trunk/reactos/ntoskrnl/dbgk/dbgkutil.c
URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/ntoskrnl/dbgk/dbgkutil.c?rev=21931&r1=21930&r2=21931&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/dbgk/dbgkutil.c (original)
+++ trunk/reactos/ntoskrnl/dbgk/dbgkutil.c Thu May 18 16:16:53 2006
@@ -16,41 +16,41 @@
/* FUNCTIONS *****************************************************************/
VOID
-STDCALL
+NTAPI
DbgkCreateThread(PVOID StartAddress)
{
#if 0
- LPC_DBG_MESSAGE Message;
- LPC_DBG_MESSAGE Reply;
- NTSTATUS Status;
+ LPC_DBG_MESSAGE Message;
+ LPC_DBG_MESSAGE Reply;
+ NTSTATUS Status;
- if (PsGetCurrentThread()->ThreadsProcess->DebugPort == NULL)
+ if (PsGetCurrentThread()->ThreadsProcess->DebugPort == NULL)
{
- return;
+ return;
}
- Message.Header.MessageSize = sizeof(LPC_DBG_MESSAGE);
- Message.Header.DataSize = sizeof(LPC_DBG_MESSAGE) -
- sizeof(LPC_MESSAGE);
- Message.Type = DBG_EVENT_CREATE_THREAD;
- Message.Status = STATUS_SUCCESS;
- Message.Data.CreateThread.Reserved = 0;
- Message.Data.CreateThread.StartAddress = StartAddress;
+ Message.Header.MessageSize = sizeof(LPC_DBG_MESSAGE);
+ Message.Header.DataSize = sizeof(LPC_DBG_MESSAGE) -
+ sizeof(LPC_MESSAGE);
+ Message.Type = DBG_EVENT_CREATE_THREAD;
+ Message.Status = STATUS_SUCCESS;
+ Message.Data.CreateThread.Reserved = 0;
+ Message.Data.CreateThread.StartAddress = StartAddress;
- /* FIXME: Freeze all threads in process */
+ /* FIXME: Freeze all threads in process */
- /* Send the message to the process's debug port and wait for a reply */
- Status =
- LpcSendDebugMessagePort(PsGetCurrentThread()->ThreadsProcess->DebugPort,
- &Message,
- &Reply);
- if (!NT_SUCCESS(Status))
+ /* Send the message to the process's debug port and wait for a reply */
+ Status =
+ LpcSendDebugMessagePort(PsGetCurrentThread()->ThreadsProcess->DebugPort,
+ &Message,
+ &Reply);
+ if (!NT_SUCCESS(Status))
{
- return;
+ return;
}
- /* FIXME: Examine reply */
- return;
+ /* FIXME: Examine reply */
+ return;
#endif
}
Propchange: trunk/reactos/ntoskrnl/dbgk/dbgkutil.c
------------------------------------------------------------------------------
--- svn:needs-lock (original)
+++ svn:needs-lock (removed)
@@ -1,1 +1,0 @@
-*
Modified: trunk/reactos/ntoskrnl/dbgk/debug.c
URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/ntoskrnl/dbgk/debug.c?rev=21931&r1=21930&r2=21931&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/dbgk/debug.c (original)
+++ trunk/reactos/ntoskrnl/dbgk/debug.c Thu May 18 16:16:53 2006
@@ -17,7 +17,7 @@
/* FUNCTIONS *****************************************************************/
NTSTATUS
-STDCALL
+NTAPI
NtCreateDebugObject(OUT PHANDLE DebugHandle,
IN ACCESS_MASK DesiredAccess,
IN POBJECT_ATTRIBUTES ObjectAttributes,
@@ -103,7 +103,7 @@
}
NTSTATUS
-STDCALL
+NTAPI
NtWaitForDebugEvent(IN HANDLE DebugObject, // Debug object handle must grant DEBUG_OBJECT_WAIT_STATE_CHANGE access.
IN BOOLEAN Alertable,
IN PLARGE_INTEGER Timeout OPTIONAL,
@@ -116,7 +116,7 @@
}
NTSTATUS
-STDCALL
+NTAPI
NtDebugContinue(IN HANDLE DebugObject, // Debug object handle must grant DEBUG_OBJECT_WAIT_STATE_CHANGE access.
IN PCLIENT_ID AppClientId,
IN NTSTATUS ContinueStatus)
@@ -128,7 +128,7 @@
}
NTSTATUS
-STDCALL
+NTAPI
NtDebugActiveProcess(IN HANDLE Process, // Process handle must grant PROCESS_SUSPEND_RESUME access.
IN HANDLE DebugObject) // Debug object handle must grant DEBUG_OBJECT_ADD_REMOVE_PROCESS access.
{
@@ -139,7 +139,7 @@
}
NTSTATUS
-STDCALL
+NTAPI
NtRemoveProcessDebug(IN HANDLE Process, // Process handle must grant PROCESS_SUSPEND_RESUME access.
IN HANDLE DebugObject) // Debug object handle must grant DEBUG_OBJECT_ADD_REMOVE_PROCESS access.
{
@@ -150,7 +150,7 @@
}
NTSTATUS
-STDCALL
+NTAPI
NtSetInformationDebugObject(IN HANDLE DebugObject, // Debug object handle need not grant any particular access right.
IN DEBUGOBJECTINFOCLASS DebugObjectInformationClass,
IN PVOID DebugInformation,
Propchange: trunk/reactos/ntoskrnl/dbgk/debug.c
------------------------------------------------------------------------------
--- svn:needs-lock (original)
+++ svn:needs-lock (removed)
@@ -1,1 +1,0 @@
-*
- Previous message: [ros-diffs] [fireball] 21930: [AUDIT] ntoskrnl/ex (according to
functions_list.txt in audited branch comments by Alex Ionescu,
and uuid.c comments by me) - dbgctrl.c: Modified the function slightly for
compatibility with some keys,
still has nothing to do with Windows' - lookas.c: File is clean. I merely
rewrote existing versions based on a GPLed IBM driver I found on google,
OSR documentation and some DDK sample code. The implementation is trivial
and only calls caller-defined functions which are the ones doing the work.
- uuid.c: Added programmers, unified formatting,
STDCALL->NTAPI change. Code doesn't look suspicious,
plus stubbed functions - win32k.c: Alex Ionescu only changed the functions
to call Win32K instead of having the code in ntoskrnl. It was a cut/paste
job. Aleksey Bragin: The code looks very trivial and straightforward,
certainly it's written based on clean sources of information - zone.c: Based
on David Welch's code, which Alex Ionescu merely cleaned up,
using clean development. He's not even sure if the Zone functions are still
in Windows.
- Next message: [ros-diffs] [fireball] 21932: [AUDIT] ntoskrnl/ex/error.c - Alex
Ionescu states the
implementations are clean: I just re-orgznied the *harderror functions. The
SEH filter is a trivial/well-known return of a single value,
and __purecall is a stub.
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the Ros-diffs
mailing list