[ros-diffs] [hpoussin] 24503: Disable DbgBreakPoint() in release versions. This lets "copy nul com1:" fail instead of crashing. Next task: fix cmd.exe to let the command succeed

hpoussin at svn.reactos.org hpoussin at svn.reactos.org
Fri Oct 13 16:31:57 CEST 2006


Author: hpoussin
Date: Fri Oct 13 18:31:57 2006
New Revision: 24503

URL: http://svn.reactos.org/svn/reactos?rev=24503&view=rev
Log:
Disable DbgBreakPoint() in release versions. This lets "copy nul com1:" fail instead of crashing.
Next task: fix cmd.exe to let the command succeed

Modified:
    trunk/reactos/drivers/bus/serenum/serenum.c

Modified: trunk/reactos/drivers/bus/serenum/serenum.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/serenum/serenum.c?rev=24503&r1=24502&r2=24503&view=diff
==============================================================================
--- trunk/reactos/drivers/bus/serenum/serenum.c (original)
+++ trunk/reactos/drivers/bus/serenum/serenum.c Fri Oct 13 18:31:57 2006
@@ -7,7 +7,7 @@
  * PROGRAMMERS:     Hervé Poussineau (hpoussin at reactos.com)
  */
 
-//#define NDEBUG
+#define NDEBUG
 #define INITGUID
 #include "serenum.h"
 
@@ -51,9 +51,7 @@
 			{
 				DPRINT1("Serenum: FDO stub for major function 0x%lx\n",
 					IoGetCurrentIrpStackLocation(Irp)->MajorFunction);
-#ifndef NDEBUG
-				DbgBreakPoint();
-#endif
+				ASSERT(FALSE);
 				Status = Irp->IoStatus.Status;
 			}
 		}
@@ -74,9 +72,7 @@
 			{
 				DPRINT1("Serenum: PDO stub for major function 0x%lx\n",
 					IoGetCurrentIrpStackLocation(Irp)->MajorFunction);
-#ifndef NDEBUG
-				DbgBreakPoint();
-#endif
+				ASSERT(FALSE);
 				Status = Irp->IoStatus.Status;
 			}
 		}




More information about the Ros-diffs mailing list