[ros-diffs] [cfinck] 31378: Changes by Carlo Bramini (carlo.bramix at libero.it): - Convert the app from ANSI to TCHAR and enable Unicode compilation in the .rbuild file - Dialog procedures now return INT_PTR instead of BOOL - IDS_NOBODY has been added to the resource files - Fixed a bug in SetDifficulty(): If custom selection, then no changes are done if the user presses the CANCEL button. - Show mines in the end board in all mine boxes, which you previously marked with the QUESTION state, when you lost the game - Added an accelerator table - Define the WineMine root registry key in just one place as a constant rather than a #define, point it to the Software\Microsoft\WinMine key - Code simplifications Changes by me: - Make our registry settings compatible with the MS WinMine settings, since we write into the WinMine registry key now - Remove the WINE_STRICT check, which was needed to avoid an ancient WINE bug, but doesn't affect our tree. I also replaced all NULL_HANDLE's by NULL. - Remove the IDS_APPNAME string, we use "WineMine" as a static constant for the application name now - Remove the unused "mb" variable from the BOARD structure - Load all resources by ID, not by name - Add a manifest for enabling Common Controls 6.0 - Use ShellAbout instead of a custom About dialog - Use a consistent indentation and consistent variable namings and types See issue #2815 for more details.

cfinck at svn.reactos.org cfinck at svn.reactos.org
Fri Dec 21 22:29:58 CET 2007


Author: cfinck
Date: Sat Dec 22 00:29:57 2007
New Revision: 31378

URL: http://svn.reactos.org/svn/reactos?rev=31378&view=rev
Log:
Changes by Carlo Bramini (carlo.bramix at libero.it):
- Convert the app from ANSI to TCHAR and enable Unicode compilation in the .rbuild file
- Dialog procedures now return INT_PTR instead of BOOL
- IDS_NOBODY has been added to the resource files
- Fixed a bug in SetDifficulty(): If custom selection, then no changes are done if the user presses the CANCEL button.
- Show mines in the end board in all mine boxes, which you previously marked with the QUESTION state, when you lost the game
- Added an accelerator table
- Define the WineMine root registry key in just one place as a constant rather than a #define, point it to the Software\Microsoft\WinMine key
- Code simplifications

Changes by me:
- Make our registry settings compatible with the MS WinMine settings, since we write into the WinMine registry key now
- Remove the WINE_STRICT check, which was needed to avoid an ancient WINE bug, but doesn't affect our tree. I also replaced all NULL_HANDLE's by NULL.
- Remove the IDS_APPNAME string, we use "WineMine" as a static constant for the application name now
- Remove the unused "mb" variable from the BOARD structure
- Load all resources by ID, not by name
- Add a manifest for enabling Common Controls 6.0
- Use ShellAbout instead of a custom About dialog
- Use a consistent indentation and consistent variable namings and types

See issue #2815 for more details.

Added:
    trunk/reactos/base/applications/games/winemine/manifest.xml   (with props)
Modified:
    trunk/reactos/base/applications/games/winemine/dialog.c
    trunk/reactos/base/applications/games/winemine/dialog.h
    trunk/reactos/base/applications/games/winemine/lang/bg-BG.rc
    trunk/reactos/base/applications/games/winemine/lang/ca-ES.rc
    trunk/reactos/base/applications/games/winemine/lang/de-DE.rc
    trunk/reactos/base/applications/games/winemine/lang/el-GR.rc
    trunk/reactos/base/applications/games/winemine/lang/en-US.rc
    trunk/reactos/base/applications/games/winemine/lang/es-ES.rc
    trunk/reactos/base/applications/games/winemine/lang/fr-FR.rc
    trunk/reactos/base/applications/games/winemine/lang/id-ID.rc
    trunk/reactos/base/applications/games/winemine/lang/it-IT.rc
    trunk/reactos/base/applications/games/winemine/lang/lt-LT.rc
    trunk/reactos/base/applications/games/winemine/lang/nb-NO.rc
    trunk/reactos/base/applications/games/winemine/lang/nl-NL.rc
    trunk/reactos/base/applications/games/winemine/lang/pl-PL.rc
    trunk/reactos/base/applications/games/winemine/lang/ru-RU.rc
    trunk/reactos/base/applications/games/winemine/lang/sk-SK.rc
    trunk/reactos/base/applications/games/winemine/lang/th-TH.rc
    trunk/reactos/base/applications/games/winemine/lang/uk-UA.rc
    trunk/reactos/base/applications/games/winemine/lang/zh-CN.rc
    trunk/reactos/base/applications/games/winemine/main.c
    trunk/reactos/base/applications/games/winemine/main.h
    trunk/reactos/base/applications/games/winemine/resource.h
    trunk/reactos/base/applications/games/winemine/rsrc.rc
    trunk/reactos/base/applications/games/winemine/winemine.rbuild

[This mail would be too long, it was shortened to contain the URLs only.]

Modified: trunk/reactos/base/applications/games/winemine/dialog.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/dialog.c?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/dialog.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/dialog.h?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/bg-BG.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/bg-BG.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/ca-ES.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/ca-ES.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/de-DE.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/de-DE.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/el-GR.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/el-GR.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/en-US.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/en-US.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/es-ES.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/es-ES.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/fr-FR.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/fr-FR.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/id-ID.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/id-ID.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/it-IT.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/it-IT.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/lt-LT.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/lt-LT.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/nb-NO.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/nb-NO.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/nl-NL.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/nl-NL.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/pl-PL.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/pl-PL.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/ru-RU.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/ru-RU.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/sk-SK.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/sk-SK.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/th-TH.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/th-TH.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/uk-UA.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/uk-UA.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/lang/zh-CN.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/lang/zh-CN.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/main.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/main.c?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/main.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/main.h?rev=31378&r1=31377&r2=31378&view=diff

Added: trunk/reactos/base/applications/games/winemine/manifest.xml
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/manifest.xml?rev=31378&view=auto

Modified: trunk/reactos/base/applications/games/winemine/resource.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/resource.h?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/rsrc.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/rsrc.rc?rev=31378&r1=31377&r2=31378&view=diff

Modified: trunk/reactos/base/applications/games/winemine/winemine.rbuild
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/winemine/winemine.rbuild?rev=31378&r1=31377&r2=31378&view=diff




More information about the Ros-diffs mailing list