[ros-diffs] [gedmurphy] 27382: - Add some UNIMPLEMENTED macros to highlight API's being called - Reformat the code, no other changes

gedmurphy at svn.reactos.org gedmurphy at svn.reactos.org
Wed Jul 4 10:26:47 CEST 2007


Author: gedmurphy
Date: Wed Jul  4 12:26:47 2007
New Revision: 27382

URL: http://svn.reactos.org/svn/reactos?rev=27382&view=rev
Log:
- Add some UNIMPLEMENTED macros to highlight API's being called
- Reformat the code, no other changes

Modified:
    trunk/reactos/ntoskrnl/po/power.c

Modified: trunk/reactos/ntoskrnl/po/power.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/po/power.c?rev=27382&r1=27381&r2=27382&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/po/power.c (original)
+++ trunk/reactos/ntoskrnl/po/power.c Wed Jul  4 12:26:47 2007
@@ -17,9 +17,9 @@
 
 typedef struct _REQUEST_POWER_ITEM
 {
-  PREQUEST_POWER_COMPLETE CompletionRoutine;
-  POWER_STATE PowerState;
-  PVOID Context;
+    PREQUEST_POWER_COMPLETE CompletionRoutine;
+    POWER_STATE PowerState;
+    PVOID Context;
 } REQUEST_POWER_ITEM, *PREQUEST_POWER_ITEM;
 
 PDEVICE_NODE PopSystemPowerDeviceNode = NULL;
@@ -30,15 +30,14 @@
  */
 NTSTATUS
 STDCALL
-PoCallDriver(
-  IN PDEVICE_OBJECT DeviceObject,
-  IN OUT PIRP Irp)
-{
-  NTSTATUS Status;
-
-  Status = IoCallDriver(DeviceObject, Irp);
-
-  return Status;
+PoCallDriver(IN PDEVICE_OBJECT DeviceObject,
+             IN OUT PIRP Irp)
+{
+    NTSTATUS Status;
+
+    Status = IoCallDriver(DeviceObject, Irp);
+
+    return Status;
 }
 
 /*
@@ -46,13 +45,13 @@
  */
 PULONG
 STDCALL
-PoRegisterDeviceForIdleDetection(
-  IN PDEVICE_OBJECT DeviceObject,
-  IN ULONG ConservationIdleTime,
-  IN ULONG PerformanceIdleTime,
-  IN DEVICE_POWER_STATE State)
-{
-  return NULL;
+PoRegisterDeviceForIdleDetection(IN PDEVICE_OBJECT DeviceObject,
+                                 IN ULONG ConservationIdleTime,
+                                 IN ULONG PerformanceIdleTime,
+                                 IN DEVICE_POWER_STATE State)
+{
+    UNIMPLEMENTED;
+    return NULL;
 }
 
 /*
@@ -60,36 +59,36 @@
  */
 PVOID
 STDCALL
-PoRegisterSystemState(
-  IN PVOID StateHandle,
-  IN EXECUTION_STATE Flags)
-{
-  return NULL;
+PoRegisterSystemState(IN PVOID StateHandle,
+                      IN EXECUTION_STATE Flags)
+{
+    UNIMPLEMENTED;
+    return NULL;
 }
 
 static
-NTSTATUS STDCALL
-PopRequestPowerIrpCompletion(
-  IN PDEVICE_OBJECT DeviceObject,
-  IN PIRP Irp,
-  IN PVOID Context)
-{
-  PIO_STACK_LOCATION Stack;
-  PREQUEST_POWER_ITEM RequestPowerItem;
-  
-  Stack = IoGetNextIrpStackLocation(Irp);
-  RequestPowerItem = (PREQUEST_POWER_ITEM)Context;
-  
-  RequestPowerItem->CompletionRoutine(
-    DeviceObject,
-    Stack->MinorFunction,
-    RequestPowerItem->PowerState,
-    RequestPowerItem->Context,
-    &Irp->IoStatus);
-  
-  ExFreePool(&Irp->IoStatus);
-  ExFreePool(Context);
-  return STATUS_SUCCESS;
+NTSTATUS
+STDCALL
+PopRequestPowerIrpCompletion(IN PDEVICE_OBJECT DeviceObject,
+                             IN PIRP Irp,
+                             IN PVOID Context)
+{
+    PIO_STACK_LOCATION Stack;
+    PREQUEST_POWER_ITEM RequestPowerItem;
+  
+    Stack = IoGetNextIrpStackLocation(Irp);
+    RequestPowerItem = (PREQUEST_POWER_ITEM)Context;
+  
+    RequestPowerItem->CompletionRoutine(DeviceObject,
+                                        Stack->MinorFunction,
+                                        RequestPowerItem->PowerState,
+                                        RequestPowerItem->Context,
+                                        &Irp->IoStatus);
+  
+    ExFreePool(&Irp->IoStatus);
+    ExFreePool(Context);
+
+    return STATUS_SUCCESS;
 }
 
 /*
@@ -97,80 +96,78 @@
  */
 NTSTATUS
 STDCALL
-PoRequestPowerIrp(
-  IN PDEVICE_OBJECT DeviceObject,
-  IN UCHAR MinorFunction,
-  IN POWER_STATE PowerState,
-  IN PREQUEST_POWER_COMPLETE CompletionFunction,
-  IN PVOID Context,
-  OUT PIRP *pIrp OPTIONAL)
-{
-  PDEVICE_OBJECT TopDeviceObject;
-  PIO_STACK_LOCATION Stack;
-  PIRP Irp;
-  PIO_STATUS_BLOCK IoStatusBlock;
-  PREQUEST_POWER_ITEM RequestPowerItem;
-  NTSTATUS Status;
-  
-  if (MinorFunction != IRP_MN_QUERY_POWER
-    && MinorFunction != IRP_MN_SET_POWER
-    && MinorFunction != IRP_MN_WAIT_WAKE)
-    return STATUS_INVALID_PARAMETER_2;
-  
-  RequestPowerItem = ExAllocatePool(NonPagedPool, sizeof(REQUEST_POWER_ITEM));
-  if (!RequestPowerItem)
-    return STATUS_INSUFFICIENT_RESOURCES;
-  IoStatusBlock = ExAllocatePool(NonPagedPool, sizeof(IO_STATUS_BLOCK));
-  if (!IoStatusBlock)
-  {
-    ExFreePool(RequestPowerItem);
-    return STATUS_INSUFFICIENT_RESOURCES;
-  }
-  
-  /* Always call the top of the device stack */
-  TopDeviceObject = IoGetAttachedDeviceReference(DeviceObject);
-  
-  Irp = IoBuildSynchronousFsdRequest(
-    IRP_MJ_PNP,
-    TopDeviceObject,
-    NULL,
-    0,
-    NULL,
-    NULL,
-    IoStatusBlock);
-  if (!Irp)
-  {
-    ExFreePool(RequestPowerItem);
-    ExFreePool(IoStatusBlock);
-    return STATUS_INSUFFICIENT_RESOURCES;
-  }
-  
-  /* POWER IRPs are always initialized with a status code of
-     STATUS_NOT_IMPLEMENTED */
-  Irp->IoStatus.Status = STATUS_NOT_IMPLEMENTED;
-  Irp->IoStatus.Information = 0;
-  
-  Stack = IoGetNextIrpStackLocation(Irp);
-  Stack->MinorFunction = MinorFunction;
-  if (MinorFunction == IRP_MN_WAIT_WAKE)
-    Stack->Parameters.WaitWake.PowerState = PowerState.SystemState;
-  else
-    Stack->Parameters.WaitWake.PowerState = PowerState.DeviceState;
-  
-  RequestPowerItem->CompletionRoutine = CompletionFunction;
-  RequestPowerItem->PowerState = PowerState;
-  RequestPowerItem->Context = Context;
-  
-  if (pIrp != NULL)
-    *pIrp = Irp;
-  
-  IoSetCompletionRoutine(Irp, PopRequestPowerIrpCompletion, RequestPowerItem, TRUE, TRUE, TRUE);
-  Status = IoCallDriver(TopDeviceObject, Irp);
-  
-  /* Always return STATUS_PENDING. The completion routine
-   * will call CompletionFunction and complete the Irp.
-   */
-  return STATUS_PENDING;
+PoRequestPowerIrp(IN PDEVICE_OBJECT DeviceObject,
+                  IN UCHAR MinorFunction,
+                  IN POWER_STATE PowerState,
+                  IN PREQUEST_POWER_COMPLETE CompletionFunction,
+                  IN PVOID Context,
+                  OUT PIRP *pIrp OPTIONAL)
+{
+    PDEVICE_OBJECT TopDeviceObject;
+    PIO_STACK_LOCATION Stack;
+    PIRP Irp;
+    PIO_STATUS_BLOCK IoStatusBlock;
+    PREQUEST_POWER_ITEM RequestPowerItem;
+    NTSTATUS Status;
+  
+    if (MinorFunction != IRP_MN_QUERY_POWER
+        && MinorFunction != IRP_MN_SET_POWER
+        && MinorFunction != IRP_MN_WAIT_WAKE)
+        return STATUS_INVALID_PARAMETER_2;
+  
+    RequestPowerItem = ExAllocatePool(NonPagedPool, sizeof(REQUEST_POWER_ITEM));
+    if (!RequestPowerItem)
+        return STATUS_INSUFFICIENT_RESOURCES;
+    IoStatusBlock = ExAllocatePool(NonPagedPool, sizeof(IO_STATUS_BLOCK));
+    if (!IoStatusBlock)
+    {
+        ExFreePool(RequestPowerItem);
+        return STATUS_INSUFFICIENT_RESOURCES;
+    }
+  
+    /* Always call the top of the device stack */
+    TopDeviceObject = IoGetAttachedDeviceReference(DeviceObject);
+  
+    Irp = IoBuildSynchronousFsdRequest(IRP_MJ_PNP,
+                                       TopDeviceObject,
+                                       NULL,
+                                       0,
+                                       NULL,
+                                       NULL,
+                                       IoStatusBlock);
+    if (!Irp)
+    {
+        ExFreePool(RequestPowerItem);
+        ExFreePool(IoStatusBlock);
+        return STATUS_INSUFFICIENT_RESOURCES;
+    }
+  
+    /* POWER IRPs are always initialized with a status code of
+       STATUS_NOT_IMPLEMENTED */
+    Irp->IoStatus.Status = STATUS_NOT_IMPLEMENTED;
+    Irp->IoStatus.Information = 0;
+  
+    Stack = IoGetNextIrpStackLocation(Irp);
+    Stack->MinorFunction = MinorFunction;
+    if (MinorFunction == IRP_MN_WAIT_WAKE)
+        Stack->Parameters.WaitWake.PowerState = PowerState.SystemState;
+    else
+        Stack->Parameters.WaitWake.PowerState = PowerState.DeviceState;
+  
+    RequestPowerItem->CompletionRoutine = CompletionFunction;
+    RequestPowerItem->PowerState = PowerState;
+    RequestPowerItem->Context = Context;
+  
+    if (pIrp != NULL)
+        *pIrp = Irp;
+  
+    IoSetCompletionRoutine(Irp, PopRequestPowerIrpCompletion, RequestPowerItem, TRUE, TRUE, TRUE);
+    Status = IoCallDriver(TopDeviceObject, Irp);
+  
+    /* Always return STATUS_PENDING. The completion routine
+     * will call CompletionFunction and complete the Irp.
+     */
+    return STATUS_PENDING;
 }
 
 #undef PoSetDeviceBusy
@@ -178,6 +175,7 @@
 NTAPI
 PoSetDeviceBusy(IN PULONG IdlePointer)
 {
+    UNIMPLEMENTED;
     *IdlePointer = 0;
 }
 
@@ -185,7 +183,7 @@
 NTAPI
 PopCleanupPowerState(IN PPOWER_STATE PowerState)
 {
-    /* FIXME */
+    //UNIMPLEMENTED;
 }
 
 /*
@@ -193,111 +191,111 @@
  */
 POWER_STATE
 STDCALL
-PoSetPowerState(
-  IN PDEVICE_OBJECT DeviceObject,
-  IN POWER_STATE_TYPE Type,
-  IN POWER_STATE State)
-{
-  POWER_STATE ps;
-
-  ASSERT_IRQL(DISPATCH_LEVEL);
-
-  ps.SystemState = PowerSystemWorking;  // Fully on
-  ps.DeviceState = PowerDeviceD0;       // Fully on
-
-  return ps;
-}
-
-/*
- * @unimplemented
- */
-VOID
-STDCALL
-PoSetSystemState(
-  IN EXECUTION_STATE Flags)
-{
-}
-
-/*
- * @unimplemented
- */
-VOID
-STDCALL
-PoStartNextPowerIrp(
-  IN PIRP Irp)
-{
-}
-
-/*
- * @unimplemented
- */
-VOID
-STDCALL
-PoUnregisterSystemState(
-  IN PVOID StateHandle)
-{
-}
-
-NTSTATUS
-NTAPI
-PopSetSystemPowerState(
-  SYSTEM_POWER_STATE PowerState)
-{
-  IO_STATUS_BLOCK IoStatusBlock;
-  PDEVICE_OBJECT DeviceObject;
-  PIO_STACK_LOCATION IrpSp;
-  PDEVICE_OBJECT Fdo;
-  NTSTATUS Status;
-  KEVENT Event;
-  PIRP Irp;
-
-  if (!PopAcpiPresent) return STATUS_NOT_IMPLEMENTED;
-
-  Status = IopGetSystemPowerDeviceObject(&DeviceObject);
-  if (!NT_SUCCESS(Status)) {
-    CPRINT("No system power driver available\n");
-    return STATUS_UNSUCCESSFUL;
-  }
-
-  Fdo = IoGetAttachedDeviceReference(DeviceObject);
-
-  if (Fdo == DeviceObject)
-    {
-      DPRINT("An FDO was not attached\n");
-      return STATUS_UNSUCCESSFUL;
-    }
-
-  KeInitializeEvent(&Event,
-	  NotificationEvent,
-	  FALSE);
-
-  Irp = IoBuildSynchronousFsdRequest(IRP_MJ_POWER,
-    Fdo,
-	  NULL,
-	  0,
-	  NULL,
-	  &Event,
-	  &IoStatusBlock);
-
-  IrpSp = IoGetNextIrpStackLocation(Irp);
-  IrpSp->MinorFunction = IRP_MN_SET_POWER;
-  IrpSp->Parameters.Power.Type = SystemPowerState;
-  IrpSp->Parameters.Power.State.SystemState = PowerState;
-
-	Status = PoCallDriver(Fdo, Irp);
-	if (Status == STATUS_PENDING)
-	  {
-		  KeWaitForSingleObject(&Event,
-		                        Executive,
-		                        KernelMode,
-		                        FALSE,
-		                        NULL);
+PoSetPowerState(IN PDEVICE_OBJECT DeviceObject,
+                IN POWER_STATE_TYPE Type,
+                IN POWER_STATE State)
+{
+    POWER_STATE ps;
+
+    ASSERT_IRQL(DISPATCH_LEVEL);
+
+    ps.SystemState = PowerSystemWorking;  // Fully on
+    ps.DeviceState = PowerDeviceD0;       // Fully on
+
+    return ps;
+}
+
+/*
+ * @unimplemented
+ */
+VOID
+STDCALL
+PoSetSystemState(IN EXECUTION_STATE Flags)
+{
+    UNIMPLEMENTED;
+}
+
+/*
+ * @unimplemented
+ */
+VOID
+STDCALL
+PoStartNextPowerIrp(IN PIRP Irp)
+{
+    UNIMPLEMENTED;
+}
+
+/*
+ * @unimplemented
+ */
+VOID
+STDCALL
+PoUnregisterSystemState(IN PVOID StateHandle)
+{
+    UNIMPLEMENTED;
+}
+
+NTSTATUS
+NTAPI
+PopSetSystemPowerState(SYSTEM_POWER_STATE PowerState)
+{
+    IO_STATUS_BLOCK IoStatusBlock;
+    PDEVICE_OBJECT DeviceObject;
+    PIO_STACK_LOCATION IrpSp;
+    PDEVICE_OBJECT Fdo;
+    NTSTATUS Status;
+    KEVENT Event;
+    PIRP Irp;
+
+    if (!PopAcpiPresent) return STATUS_NOT_IMPLEMENTED;
+
+    Status = IopGetSystemPowerDeviceObject(&DeviceObject);
+    if (!NT_SUCCESS(Status)) 
+    {
+        CPRINT("No system power driver available\n");
+        return STATUS_UNSUCCESSFUL;
+    }
+
+    Fdo = IoGetAttachedDeviceReference(DeviceObject);
+
+    if (Fdo == DeviceObject)
+    {
+        DPRINT("An FDO was not attached\n");
+        return STATUS_UNSUCCESSFUL;
+    }
+
+    KeInitializeEvent(&Event,
+                      NotificationEvent,
+                      FALSE);
+
+    Irp = IoBuildSynchronousFsdRequest(IRP_MJ_POWER,
+                                       Fdo,
+                                       NULL,
+                                       0,
+                                       NULL,
+                                       &Event,
+                                       &IoStatusBlock);
+
+    IrpSp = IoGetNextIrpStackLocation(Irp);
+    IrpSp->MinorFunction = IRP_MN_SET_POWER;
+    IrpSp->Parameters.Power.Type = SystemPowerState;
+    IrpSp->Parameters.Power.State.SystemState = PowerState;
+
+    DPRINT("Calling ACPI driver");
+    Status = PoCallDriver(Fdo, Irp);
+    if (Status == STATUS_PENDING)
+    {
+        KeWaitForSingleObject(&Event,
+                              Executive,
+                              KernelMode,
+                              FALSE,
+                              NULL);
       Status = IoStatusBlock.Status;
     }
 
-  ObDereferenceObject(Fdo);
-
-  return Status;
+    ObDereferenceObject(Fdo);
+
+    return Status;
 }
 
 BOOLEAN
@@ -395,79 +393,75 @@
  */
 NTSTATUS
 STDCALL
-NtInitiatePowerAction (
-	IN POWER_ACTION SystemAction,
-	IN SYSTEM_POWER_STATE MinSystemState,
- 	IN ULONG Flags,
-	IN BOOLEAN Asynchronous)
-{
-	UNIMPLEMENTED;
-	return STATUS_NOT_IMPLEMENTED;
-}
-
-/*
- * @unimplemented
- */
-NTSTATUS
-STDCALL
-NtPowerInformation(
-	IN POWER_INFORMATION_LEVEL PowerInformationLevel,
-	IN PVOID InputBuffer  OPTIONAL,
-	IN ULONG InputBufferLength,
-	OUT PVOID OutputBuffer  OPTIONAL,
-	IN ULONG OutputBufferLength
-	)
-{
-   NTSTATUS Status;
-
-   PAGED_CODE();
-
-   DPRINT("NtPowerInformation(PowerInformationLevel 0x%x, InputBuffer 0x%x, "
-          "InputBufferLength 0x%x, OutputBuffer 0x%x, OutputBufferLength 0x%x)\n",
-          PowerInformationLevel,
-          InputBuffer, InputBufferLength,
-          OutputBuffer, OutputBufferLength);
-   switch (PowerInformationLevel)
-   {
-   case SystemBatteryState:
-      {
-      PSYSTEM_BATTERY_STATE BatteryState = (PSYSTEM_BATTERY_STATE)OutputBuffer;
-
-      if (InputBuffer != NULL)
-         return STATUS_INVALID_PARAMETER;
-      if (OutputBufferLength < sizeof(SYSTEM_BATTERY_STATE))
-         return STATUS_BUFFER_TOO_SMALL;
-
-      /* Just zero the struct (and thus set BatteryState->BatteryPresent = FALSE) */
-      RtlZeroMemory(BatteryState, sizeof(SYSTEM_BATTERY_STATE));
-      BatteryState->EstimatedTime = (ULONG)-1;
-
-      Status = STATUS_SUCCESS;
-      break;
-      }
-
-   default:
-      Status = STATUS_NOT_IMPLEMENTED;
-      DPRINT1("PowerInformationLevel 0x%x is UNIMPLEMENTED! Have a nice day.\n",
-              PowerInformationLevel);
-      break;
-   }
-
-   return Status;
-}
-
-
-NTSTATUS
-STDCALL
-PoQueueShutdownWorkItem(
-	IN PWORK_QUEUE_ITEM WorkItem
-	)
-{
-  PAGED_CODE();
-
-  DPRINT1("PoQueueShutdownWorkItem(%p)\n", WorkItem);
-
-  return STATUS_NOT_IMPLEMENTED;
+NtInitiatePowerAction (IN POWER_ACTION SystemAction,
+                       IN SYSTEM_POWER_STATE MinSystemState,
+                       IN ULONG Flags,
+                       IN BOOLEAN Asynchronous)
+{
+    UNIMPLEMENTED;
+    return STATUS_NOT_IMPLEMENTED;
+}
+
+/*
+ * @unimplemented
+ */
+NTSTATUS
+STDCALL
+NtPowerInformation(IN POWER_INFORMATION_LEVEL PowerInformationLevel,
+                   IN PVOID InputBuffer  OPTIONAL,
+                   IN ULONG InputBufferLength,
+                   OUT PVOID OutputBuffer  OPTIONAL,
+                   IN ULONG OutputBufferLength)
+{
+    NTSTATUS Status;
+
+    PAGED_CODE();
+
+    DPRINT("NtPowerInformation(PowerInformationLevel 0x%x, InputBuffer 0x%x, "
+           "InputBufferLength 0x%x, OutputBuffer 0x%x, OutputBufferLength 0x%x)\n",
+           PowerInformationLevel,
+           InputBuffer, InputBufferLength,
+           OutputBuffer, OutputBufferLength);
+    
+    switch (PowerInformationLevel)
+    {
+        case SystemBatteryState:
+        {
+            PSYSTEM_BATTERY_STATE BatteryState = (PSYSTEM_BATTERY_STATE)OutputBuffer;
+
+            if (InputBuffer != NULL)
+                return STATUS_INVALID_PARAMETER;
+            if (OutputBufferLength < sizeof(SYSTEM_BATTERY_STATE))
+                return STATUS_BUFFER_TOO_SMALL;
+
+            /* Just zero the struct (and thus set BatteryState->BatteryPresent = FALSE) */
+            RtlZeroMemory(BatteryState, sizeof(SYSTEM_BATTERY_STATE));
+            BatteryState->EstimatedTime = (ULONG)-1;
+
+            Status = STATUS_SUCCESS;
+            break;
+        }
+
+        default:
+            Status = STATUS_NOT_IMPLEMENTED;
+            DPRINT1("PowerInformationLevel 0x%x is UNIMPLEMENTED! Have a nice day.\n",
+                    PowerInformationLevel);
+            break;
+    }
+
+    return Status;
+}
+
+
+NTSTATUS
+STDCALL
+PoQueueShutdownWorkItem(IN PWORK_QUEUE_ITEM WorkItem)
+{
+    PAGED_CODE();
+
+    DPRINT1("PoQueueShutdownWorkItem(%p)\n", WorkItem);
+
+    return STATUS_NOT_IMPLEMENTED;
 }
 
 NTSTATUS




More information about the Ros-diffs mailing list