[ros-diffs] [fireball] 29834: - Revert 29702 (IopParseDeviceHack is still required in 1st stage, and the Real Bug is at some other place, so no need in masking it away by doing calls which avoid buggy operation).

fireball at svn.reactos.org fireball at svn.reactos.org
Tue Oct 23 21:19:07 CEST 2007


Author: fireball
Date: Tue Oct 23 23:19:06 2007
New Revision: 29834

URL: http://svn.reactos.org/svn/reactos?rev=29834&view=rev
Log:
- Revert 29702 (IopParseDeviceHack is still required in 1st stage, and the Real Bug is at some other place, so no need in masking it away by doing calls which avoid buggy operation).

Modified:
    trunk/reactos/ntoskrnl/fstub/disksup.c
    trunk/reactos/ntoskrnl/io/iomgr/file.c

Modified: trunk/reactos/ntoskrnl/fstub/disksup.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fstub/disksup.c?rev=29834&r1=29833&r2=29834&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/fstub/disksup.c (original)
+++ trunk/reactos/ntoskrnl/fstub/disksup.c Tue Oct 23 23:19:06 2007
@@ -481,7 +481,7 @@
             NULL);
 
         Status = ZwOpenFile(&FileHandle,
-            FILE_READ_ATTRIBUTES | SYNCHRONIZE,
+            FILE_READ_DATA | SYNCHRONIZE,
             &ObjectAttributes,
             &StatusBlock,
             FILE_SHARE_READ,

Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?rev=29834&r1=29833&r2=29834&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/file.c (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/file.c Tue Oct 23 23:19:06 2007
@@ -404,9 +404,6 @@
 
     /* FIXME: Small hack still exists, have to check why...
      * This is triggered multiple times by usetup and then once per boot.
-     * TMN: NOTE: It might have been fixed now, by changing the requested
-     * openmode in xHalIoAssignDriveLetters from FILE_READ_DATA to
-     * FILE_READ_ATTRIBUTES. If verified, this hack should be removed.
      */
     if (!(DirectOpen) &&
         !(RemainingName->Length) &&




More information about the Ros-diffs mailing list