[ros-diffs] [hpoussin] 28895: Explain why some binutils are blacklisted

[hpoussin at svn.reactos.org]

Author: hpoussin
Date: Thu Sep  6 12:25:57 2007
New Revision: 28895

URL: http://svn.reactos.org/svn/reactos?rev=28895&view=rev
Log:
Explain why some binutils are blacklisted

Modified:
    trunk/reactos/tools/rbuild/backend/mingw/mingw.cpp

Modified: trunk/reactos/tools/rbuild/backend/mingw/mingw.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/backend/mingw/mingw.cpp?rev=28895&r1=28894&r2=28895&view=diff
==============================================================================
--- trunk/reactos/tools/rbuild/backend/mingw/mingw.cpp (original)
+++ trunk/reactos/tools/rbuild/backend/mingw/mingw.cpp Thu Sep  6 12:25:57 2007
@@ -890,14 +890,20 @@
 MingwBackend::IsSupportedBinutilsVersion ( const string& binutilsVersion )
 {
 	if ( manualBinutilsSetting ) return true;
-	
+
 	/* linux */
 	if ( binutilsVersion.find('.') != std::string::npos )
 	{
-		/* TODO: blacklist versions on version number instead of date */		
+		/* TODO: blacklist versions on version number instead of date */
 		return true;
 	}
 
+	/*
+	 * - Binutils older than 2003/10/01 have broken windres which can't handle
+	 *   icons with alpha channel.
+	 * - Binutils between 2004/09/02 and 2004/10/08 have broken handling of
+	 *   forward exports in dlltool.
+	 */
 	if ( ( ( strcmp ( binutilsVersion.c_str (), "20040902") >= 0 ) &&
 	       ( strcmp ( binutilsVersion.c_str (), "20041008") <= 0 ) ) ||
 	       ( strcmp ( binutilsVersion.c_str (), "20031001") < 0 ) )