[ros-diffs] [jimtabor] 38002: - Yet another victim of the Win32k Initialization BUG! - Creating an Information DC is wrong when using it with Icon Creation. This makes the default bitmap monochrome and this is why CreateCompatibleBitmap is broken. Plus all the hacks related to making it all work in Win32k.

jimtabor at svn.reactos.org jimtabor at svn.reactos.org
Wed Dec 10 22:14:03 CET 2008


Author: jimtabor
Date: Wed Dec 10 15:14:02 2008
New Revision: 38002

URL: http://svn.reactos.org/svn/reactos?rev=38002&view=rev
Log:
- Yet another victim of the Win32k Initialization BUG!
- Creating an Information DC is wrong when using it with Icon Creation. This makes the default bitmap monochrome and this is why CreateCompatibleBitmap is broken. Plus all the hacks related to making it all work in Win32k.

Modified:
    trunk/reactos/dll/win32/user32/windows/icon.c

Modified: trunk/reactos/dll/win32/user32/windows/icon.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/icon.c?rev=38002&r1=38001&r2=38002&view=diff
==============================================================================
--- trunk/reactos/dll/win32/user32/windows/icon.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/user32/windows/icon.c [iso-8859-1] Wed Dec 10 15:14:02 2008
@@ -291,6 +291,8 @@
   Data = (PBYTE)SafeIconImage + HeaderSize;
 
   /* get a handle to the screen dc, the icon we create is going to be compatable with this */
+  // FIXME!!! This is a victim of the Win32k Initialization BUG!!!!!
+  //hScreenDc = CreateDCW(NULL, NULL, NULL, NULL);
   hScreenDc = CreateCompatibleDC(NULL);
   if (hScreenDc == NULL)
     {



More information about the Ros-diffs mailing list