[ros-diffs] [fireball] 32302: - Minor cleanup. See issue #3054 for more details.

fireball at svn.reactos.org fireball at svn.reactos.org
Mon Feb 11 18:45:57 CET 2008


Author: fireball
Date: Mon Feb 11 20:45:56 2008
New Revision: 32302

URL: http://svn.reactos.org/svn/reactos?rev=32302&view=rev
Log:
- Minor cleanup.
See issue #3054 for more details.

Modified:
    trunk/reactos/ntoskrnl/mm/anonmem.c
    trunk/reactos/ntoskrnl/mm/procsup.c

Modified: trunk/reactos/ntoskrnl/mm/anonmem.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/anonmem.c?rev=32302&r1=32301&r2=32302&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/mm/anonmem.c (original)
+++ trunk/reactos/ntoskrnl/mm/anonmem.c Mon Feb 11 20:45:56 2008
@@ -542,10 +542,6 @@
  *                PAGE_EXECUTE_READ, PAGE_EXECUTE_READWRITE, PAGE_GUARD,
  *                PAGE_NOACCESS
  * RETURNS: Status
- * NOTES: Must run at IRQL PASSIVE_LEVEL? (or is APC_LEVEL cool too?)
- *        MSDN states that ZwAllocateVirtualMemory IRQL must be PASSIVE_LEVEL,
- *        but why wouldn't APC_LEVEL be valid (or is that only for the Zw* version
- *        and Nt* can indeed run at APC_LEVEL?)
  */
 {
    PEPROCESS Process;
@@ -561,10 +557,7 @@
    PHYSICAL_ADDRESS BoundaryAddressMultiple;
    KPROCESSOR_MODE PreviousMode;
 
-   // TMN: Someone Pick one of these. Until it's clear which
-   // level is allowed, I play it safe and check for <= APC_LEVEL
    PAGED_CODE();
-//   ASSERT(KeGetCurrentIrql() == PASSIVE_LEVEL);
 
    DPRINT("NtAllocateVirtualMemory(*UBaseAddress %x, "
           "ZeroBits %d, *URegionSize %x, AllocationType %x, Protect %x)\n",

Modified: trunk/reactos/ntoskrnl/mm/procsup.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/procsup.c?rev=32302&r1=32301&r2=32302&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/mm/procsup.c (original)
+++ trunk/reactos/ntoskrnl/mm/procsup.c Mon Feb 11 20:45:56 2008
@@ -636,7 +636,7 @@
         szDest = Process->ImageFileName;
         lnFName = min(lnFName, sizeof(Process->ImageFileName) - 1);
         while (lnFName--) *szDest++ = (UCHAR)*szSrc++;
-        *szDest = UNICODE_NULL;
+        *szDest = ANSI_NULL;
 
         /* Check if caller wants an audit name */
         if (AuditName)




More information about the Ros-diffs mailing list