[ros-diffs] [sginsberg] 34569: - Fix a typo in the DC_ATTR structure: mxDevicetoWorld -> mxDeviceToWorld
sginsberg at svn.reactos.org
sginsberg at svn.reactos.org
Thu Jul 17 23:54:41 CEST 2008
- Previous message: [ros-diffs] [jmorlan] 34568: Clean up console code a bit: - Get/SetConsoleTitle: Get rid of unnecessary handle creation; instead, just have csrss get the console from the ProcessData. - Instead of using ShowX/ShowY to store the origin of the buffer, use the VirtualX member that was put there for this purpose. Rename it to VirtualY, though, since it's a row number. ShowX/ShowY should hold the position of the visible window, once that's implemented. - From the CSRSS_CONSOLE structure: remove hActiveBuffer (redundant), CodePageId (unused), and hWindowIcon (only used as a temporary) - Make cursor coordinates be "logical", not "physical". This simplifies various things. - ConioConsoleFromProcessData: If process has no console, return STATUS_INVALID_HANDLE; don't pretend to succeed (causing many functions to access memory around address 0, which is probably not a good thing). Remove various Console != NULL checks which are now unnecessary.
- Next message: [ros-diffs] [sginsberg] 34570: - Patch from Samuel "encoded" Serapion (samdwise51 at gmail dot com) - Use "size_t" instead of "unsigned int" where appropriate
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Author: sginsberg
Date: Thu Jul 17 16:54:40 2008
New Revision: 34569
URL: http://svn.reactos.org/svn/reactos?rev=34569&view=rev
Log:
- Fix a typo in the DC_ATTR structure: mxDevicetoWorld -> mxDeviceToWorld
Modified:
trunk/reactos/dll/win32/gdi32/objects/coord.c
trunk/reactos/include/reactos/win32k/ntgdihdl.h
trunk/reactos/subsystems/win32/win32k/objects/dcutil.c
Modified: trunk/reactos/dll/win32/gdi32/objects/coord.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdi32/objects/coord.c?rev=34569&r1=34568&r2=34569&view=diff
==============================================================================
--- trunk/reactos/dll/win32/gdi32/objects/coord.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/gdi32/objects/coord.c [iso-8859-1] Thu Jul 17 16:54:40 2008
@@ -110,7 +110,7 @@
else
{
for ( i = 0; i < Count; i++ )
- CoordCnvP ( &Dc_Attr->mxDevicetoWorld, &Points[i] );
+ CoordCnvP ( &Dc_Attr->mxDeviceToWorld, &Points[i] );
}
return TRUE;
#endif
Modified: trunk/reactos/include/reactos/win32k/ntgdihdl.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/win32k/ntgdihdl.h?rev=34569&r1=34568&r2=34569&view=diff
==============================================================================
--- trunk/reactos/include/reactos/win32k/ntgdihdl.h [iso-8859-1] (original)
+++ trunk/reactos/include/reactos/win32k/ntgdihdl.h [iso-8859-1] Thu Jul 17 16:54:40 2008
@@ -291,7 +291,7 @@
LONG cBreak;
HANDLE hlfntNew;
MATRIX_S mxWorldToDevice;
- MATRIX_S mxDevicetoWorld;
+ MATRIX_S mxDeviceToWorld;
MATRIX_S mxWorldToPage;
EFLOAT_S efM11PtoD;
EFLOAT_S efM22PtoD;
Modified: trunk/reactos/subsystems/win32/win32k/objects/dcutil.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/objects/dcutil.c?rev=34569&r1=34568&r2=34569&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/objects/dcutil.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/objects/dcutil.c [iso-8859-1] Thu Jul 17 16:54:40 2008
@@ -114,7 +114,7 @@
{
NTSTATUS Status = STATUS_SUCCESS;
dc->Dc_Attr.mxWorldToDevice = dc->DcLevel.mxWorldToDevice;
- dc->Dc_Attr.mxDevicetoWorld = dc->DcLevel.mxDeviceToWorld;
+ dc->Dc_Attr.mxDeviceToWorld = dc->DcLevel.mxDeviceToWorld;
dc->Dc_Attr.mxWorldToPage = dc->DcLevel.mxWorldToPage;
_SEH_TRY
- Previous message: [ros-diffs] [jmorlan] 34568: Clean up console code a bit: - Get/SetConsoleTitle: Get rid of unnecessary handle creation; instead, just have csrss get the console from the ProcessData. - Instead of using ShowX/ShowY to store the origin of the buffer, use the VirtualX member that was put there for this purpose. Rename it to VirtualY, though, since it's a row number. ShowX/ShowY should hold the position of the visible window, once that's implemented. - From the CSRSS_CONSOLE structure: remove hActiveBuffer (redundant), CodePageId (unused), and hWindowIcon (only used as a temporary) - Make cursor coordinates be "logical", not "physical". This simplifies various things. - ConioConsoleFromProcessData: If process has no console, return STATUS_INVALID_HANDLE; don't pretend to succeed (causing many functions to access memory around address 0, which is probably not a good thing). Remove various Console != NULL checks which are now unnecessary.
- Next message: [ros-diffs] [sginsberg] 34570: - Patch from Samuel "encoded" Serapion (samdwise51 at gmail dot com) - Use "size_t" instead of "unsigned int" where appropriate
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the Ros-diffs
mailing list