[ros-diffs] [tkreuzer] 34868: fix definition for NdisCopyLookaheadData on AMD64
tkreuzer at svn.reactos.org
tkreuzer at svn.reactos.org
Mon Jul 28 00:58:20 CEST 2008
- Previous message: [ros-diffs] [janderwald] 34867: - implement changing drive volume name - display default volume label "local disk" if there is no title - verify that provided clsid is valid - display drive property dialog - note: changing volume label currently leads to a crash
- Next message: [ros-diffs] [ros-arm-bringup] 34869: More over-engineering: there really isn't any reason to keep track of the "LowestAddress" of the process' addres space. At first sight, this looked like a dynamic value that would define the lowest address at which the process has allocated memory, but this isn't the case -- the variable actually defines the lowest valid address a process can allocate memory at. This is pretty much a static value, that was compute by MmInitializeProcessAddressSpace, to either MM_LOWEST_USER_ADDRESS or MmSystemRangeStart, based on whether or not the address space has an owner process (meaning it is a user-mode address space) or not (meaning it is a kernel mode address space). This patch removes that value and all the complex code around checking it, and replaces it with a much simpler design: if there is an owner process, use MM_LOWEST_USER_ADDRESS during gap calculations, otherwise, use MmSystemRangeStart. This is both faster, and wastes less space by not tracking static data.
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Author: tkreuzer
Date: Sun Jul 27 17:58:20 2008
New Revision: 34868
URL: http://svn.reactos.org/svn/reactos?rev=34868&view=rev
Log:
fix definition for NdisCopyLookaheadData on AMD64
Modified:
branches/ros-amd64-bringup/reactos/include/ddk/ndis.h
Modified: branches/ros-amd64-bringup/reactos/include/ddk/ndis.h
URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/include/ddk/ndis.h?rev=34868&r1=34867&r2=34868&view=diff
==============================================================================
--- branches/ros-amd64-bringup/reactos/include/ddk/ndis.h [iso-8859-1] (original)
+++ branches/ros-amd64-bringup/reactos/include/ddk/ndis.h [iso-8859-1] Sun Jul 27 17:58:20 2008
@@ -1589,7 +1589,7 @@
* IN ULONG ReceiveFlags);
*/
-#ifdef _M_IX86
+#if defined(_M_IX86) || defined(_M_AMD64)
#define NdisCopyLookaheadData(Destination, Source, Length, MacOptions) \
RtlCopyMemory(Destination, Source, Length)
#else
- Previous message: [ros-diffs] [janderwald] 34867: - implement changing drive volume name - display default volume label "local disk" if there is no title - verify that provided clsid is valid - display drive property dialog - note: changing volume label currently leads to a crash
- Next message: [ros-diffs] [ros-arm-bringup] 34869: More over-engineering: there really isn't any reason to keep track of the "LowestAddress" of the process' addres space. At first sight, this looked like a dynamic value that would define the lowest address at which the process has allocated memory, but this isn't the case -- the variable actually defines the lowest valid address a process can allocate memory at. This is pretty much a static value, that was compute by MmInitializeProcessAddressSpace, to either MM_LOWEST_USER_ADDRESS or MmSystemRangeStart, based on whether or not the address space has an owner process (meaning it is a user-mode address space) or not (meaning it is a kernel mode address space). This patch removes that value and all the complex code around checking it, and replaces it with a much simpler design: if there is an owner process, use MM_LOWEST_USER_ADDRESS during gap calculations, otherwise, use MmSystemRangeStart. This is both faster, and wastes less space by not tracking static data.
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the Ros-diffs
mailing list