[ros-diffs] [fireball] 33339: - Assign statements in ASSERTs is a bad idea. Fix that.

fireball at svn.reactos.org fireball at svn.reactos.org
Wed May 7 11:46:37 CEST 2008


Author: fireball
Date: Wed May  7 04:46:37 2008
New Revision: 33339

URL: http://svn.reactos.org/svn/reactos?rev=33339&view=rev
Log:
- Assign statements in ASSERTs is a bad idea. Fix that.

Modified:
    trunk/reactos/ntoskrnl/ex/resource.c

Modified: trunk/reactos/ntoskrnl/ex/resource.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/resource.c?rev=33339&r1=33338&r2=33339&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/ex/resource.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ex/resource.c [iso-8859-1] Wed May  7 04:46:37 2008
@@ -1896,7 +1896,7 @@
             Resource->NumberOfSharedWaiters = 0;
             
             /* Release lock and let someone else have it */
-            ASSERT(Resource->ActiveCount = 1);
+            ASSERT(Resource->ActiveCount == 1);
             ExReleaseResourceLock(Resource, &LockHandle);
             KeReleaseSemaphore(Resource->SharedWaiters, 0, Count, FALSE);
             return;
@@ -1910,7 +1910,7 @@
             Resource->NumberOfExclusiveWaiters--;
             
             /* Release the lock and give it away */
-            ASSERT(Resource->ActiveCount = 1);
+            ASSERT(Resource->ActiveCount == 1);
             ExReleaseResourceLock(Resource, &LockHandle);
             KeSetEventBoostPriority(Resource->ExclusiveWaiters,
                                     (PKTHREAD*)&Resource->OwnerEntry.OwnerThread);
@@ -2003,7 +2003,7 @@
                 Resource->NumberOfExclusiveWaiters--;
 
                 /* Release the lock and give it away */
-                ASSERT(Resource->ActiveCount = 1);
+                ASSERT(Resource->ActiveCount == 1);
                 ExReleaseResourceLock(Resource, &LockHandle);
                 KeSetEventBoostPriority(Resource->ExclusiveWaiters,
                                         (PKTHREAD*)&Resource->OwnerEntry.OwnerThread);



More information about the Ros-diffs mailing list