[ros-diffs] [mpiulachs] 33344: - code refactoring - made more and more easily extensible: * commands automatically loaded from plugins dlls * declarative and automatic command parameter parsing * common code moved to base classes - other fixes

mpiulachs at svn.reactos.org mpiulachs at svn.reactos.org
Wed May 7 16:59:28 CEST 2008


Author: mpiulachs
Date: Wed May  7 09:59:28 2008
New Revision: 33344

URL: http://svn.reactos.org/svn/reactos?rev=33344&view=rev
Log:
- code refactoring
- made more and more easily extensible:
   * commands automatically loaded from plugins dlls
   * declarative and automatic command parameter parsing
   * common code moved to base classes
- other fixes

Added:
    trunk/irc/TechBot/TechBot.Console/ConsoleTechBotService.cs   (with props)
    trunk/irc/TechBot/TechBot.Library/Attributes/
    trunk/irc/TechBot/TechBot.Library/Attributes/CommandAttribute.cs   (with props)
    trunk/irc/TechBot/TechBot.Library/Attributes/CommandParameterAliasAttribute.cs   (with props)
    trunk/irc/TechBot/TechBot.Library/Attributes/CommandParameterAttribute.cs   (with props)
    trunk/irc/TechBot/TechBot.Library/Collections/
    trunk/irc/TechBot/TechBot.Library/Collections/CommandBuilderCollection.cs   (with props)
    trunk/irc/TechBot/TechBot.Library/Commands/ApiCommand.cs   (contents, props changed)
      - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/ApiCommand.cs
    trunk/irc/TechBot/TechBot.Library/Commands/Base/Command.cs
      - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/Command.cs
    trunk/irc/TechBot/TechBot.Library/Commands/Base/XmlLookupCommand.cs   (with props)
    trunk/irc/TechBot/TechBot.Library/Commands/BugCommand.cs   (contents, props changed)
      - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/BugCommand.cs
    trunk/irc/TechBot/TechBot.Library/Commands/ErrorCommand.cs   (contents, props changed)
      - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/ErrorCommand.cs
    trunk/irc/TechBot/TechBot.Library/Commands/HelpCommand.cs   (contents, props changed)
      - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/HelpCommand.cs
    trunk/irc/TechBot/TechBot.Library/Commands/HresultCommand.cs   (contents, props changed)
      - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/HresultCommand.cs
    trunk/irc/TechBot/TechBot.Library/Commands/NtStatusCommand.cs   (contents, props changed)
      - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/NtStatusCommand.cs
    trunk/irc/TechBot/TechBot.Library/Commands/ReactOSBugUrl.cs
      - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/ReactOSBugUrl.cs
    trunk/irc/TechBot/TechBot.Library/Commands/SambaBugUrl.cs
      - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/SambaBugUrl.cs
    trunk/irc/TechBot/TechBot.Library/Commands/SvnCommand.cs   (contents, props changed)
      - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/SvnCommand.cs
    trunk/irc/TechBot/TechBot.Library/Commands/WineBugUrl.cs
      - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/WineBugUrl.cs
    trunk/irc/TechBot/TechBot.Library/Commands/WinerrorCommand.cs   (contents, props changed)
      - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/WinerrorCommand.cs
    trunk/irc/TechBot/TechBot.Library/Commands/WmCommand.cs   (contents, props changed)
      - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/WmCommand.cs
    trunk/irc/TechBot/TechBot.Library/Factory/
    trunk/irc/TechBot/TechBot.Library/Factory/CommandBuilder.cs   (with props)
    trunk/irc/TechBot/TechBot.Library/Factory/CommandFactory.cs   (with props)
    trunk/irc/TechBot/TechBot.Library/ParametersParser.cs   (with props)
    trunk/irc/TechBot/TechBot.Library/TechBotIrcService.cs   (contents, props changed)
      - copied, changed from r31130, trunk/irc/TechBot/TechBot.Library/IrcService.cs
    trunk/irc/TechBot/TechBot/ProjectInstaller.cs   (with props)
Removed:
    trunk/irc/TechBot/Default.build
    trunk/irc/TechBot/TechBot.Library/ApiCommand.cs
    trunk/irc/TechBot/TechBot.Library/BugCommand.cs
    trunk/irc/TechBot/TechBot.Library/Command.cs
    trunk/irc/TechBot/TechBot.Library/ErrorCommand.cs
    trunk/irc/TechBot/TechBot.Library/HelpCommand.cs
    trunk/irc/TechBot/TechBot.Library/HresultCommand.cs
    trunk/irc/TechBot/TechBot.Library/IrcService.cs
    trunk/irc/TechBot/TechBot.Library/NtStatusCommand.cs
    trunk/irc/TechBot/TechBot.Library/ReactOSBugUrl.cs
    trunk/irc/TechBot/TechBot.Library/SambaBugUrl.cs
    trunk/irc/TechBot/TechBot.Library/SvnCommand.cs
    trunk/irc/TechBot/TechBot.Library/WineBugUrl.cs
    trunk/irc/TechBot/TechBot.Library/WinerrorCommand.cs
    trunk/irc/TechBot/TechBot.Library/WmCommand.cs
    trunk/irc/TechBot/TechBot.cmbx
Modified:
    trunk/irc/TechBot/TechBot.Console/Main.cs
    trunk/irc/TechBot/TechBot.Console/TechBot.Console.csproj
    trunk/irc/TechBot/TechBot.Library/Commands/Base/XmlCommand.cs
    trunk/irc/TechBot/TechBot.Library/MessageContext.cs
    trunk/irc/TechBot/TechBot.Library/ServiceOutput.cs
    trunk/irc/TechBot/TechBot.Library/TechBot.Library.csproj
    trunk/irc/TechBot/TechBot.Library/TechBotService.cs
    trunk/irc/TechBot/TechBot/ServiceThread.cs
    trunk/irc/TechBot/TechBot/TechBot.csproj
    trunk/irc/TechBot/TechBot/TechBotService.cs

[This mail would be too long, it was shortened to contain the URLs only.]

Removed: trunk/irc/TechBot/Default.build
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/Default.build?rev=33343&view=auto

Added: trunk/irc/TechBot/TechBot.Console/ConsoleTechBotService.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Console/ConsoleTechBotService.cs?rev=33344&view=auto

Modified: trunk/irc/TechBot/TechBot.Console/Main.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Console/Main.cs?rev=33344&r1=33343&r2=33344&view=diff

Modified: trunk/irc/TechBot/TechBot.Console/TechBot.Console.csproj
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Console/TechBot.Console.csproj?rev=33344&r1=33343&r2=33344&view=diff

Removed: trunk/irc/TechBot/TechBot.Library/ApiCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/ApiCommand.cs?rev=33343&view=auto

Added: trunk/irc/TechBot/TechBot.Library/Attributes/CommandAttribute.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Attributes/CommandAttribute.cs?rev=33344&view=auto

Added: trunk/irc/TechBot/TechBot.Library/Attributes/CommandParameterAliasAttribute.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Attributes/CommandParameterAliasAttribute.cs?rev=33344&view=auto

Added: trunk/irc/TechBot/TechBot.Library/Attributes/CommandParameterAttribute.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Attributes/CommandParameterAttribute.cs?rev=33344&view=auto

Removed: trunk/irc/TechBot/TechBot.Library/BugCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/BugCommand.cs?rev=33343&view=auto

Added: trunk/irc/TechBot/TechBot.Library/Collections/CommandBuilderCollection.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Collections/CommandBuilderCollection.cs?rev=33344&view=auto

Removed: trunk/irc/TechBot/TechBot.Library/Command.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Command.cs?rev=33343&view=auto

Copied: trunk/irc/TechBot/TechBot.Library/Commands/ApiCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/ApiCommand.cs)
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/ApiCommand.cs?p2=trunk/irc/TechBot/TechBot.Library/Commands/ApiCommand.cs&p1=trunk/irc/TechBot/TechBot.Library/ApiCommand.cs&r1=31130&r2=33344&rev=33344&view=diff

Copied: trunk/irc/TechBot/TechBot.Library/Commands/Base/Command.cs (from r31130, trunk/irc/TechBot/TechBot.Library/Command.cs)
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/Base/Command.cs?p2=trunk/irc/TechBot/TechBot.Library/Commands/Base/Command.cs&p1=trunk/irc/TechBot/TechBot.Library/Command.cs&r1=31130&r2=33344&rev=33344&view=diff

Modified: trunk/irc/TechBot/TechBot.Library/Commands/Base/XmlCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/Base/XmlCommand.cs?rev=33344&r1=33343&r2=33344&view=diff

Added: trunk/irc/TechBot/TechBot.Library/Commands/Base/XmlLookupCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/Base/XmlLookupCommand.cs?rev=33344&view=auto

Copied: trunk/irc/TechBot/TechBot.Library/Commands/BugCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/BugCommand.cs)
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/BugCommand.cs?p2=trunk/irc/TechBot/TechBot.Library/Commands/BugCommand.cs&p1=trunk/irc/TechBot/TechBot.Library/BugCommand.cs&r1=31130&r2=33344&rev=33344&view=diff

Copied: trunk/irc/TechBot/TechBot.Library/Commands/ErrorCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/ErrorCommand.cs)
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/ErrorCommand.cs?p2=trunk/irc/TechBot/TechBot.Library/Commands/ErrorCommand.cs&p1=trunk/irc/TechBot/TechBot.Library/ErrorCommand.cs&r1=31130&r2=33344&rev=33344&view=diff

Copied: trunk/irc/TechBot/TechBot.Library/Commands/HelpCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/HelpCommand.cs)
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/HelpCommand.cs?p2=trunk/irc/TechBot/TechBot.Library/Commands/HelpCommand.cs&p1=trunk/irc/TechBot/TechBot.Library/HelpCommand.cs&r1=31130&r2=33344&rev=33344&view=diff

Copied: trunk/irc/TechBot/TechBot.Library/Commands/HresultCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/HresultCommand.cs)
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/HresultCommand.cs?p2=trunk/irc/TechBot/TechBot.Library/Commands/HresultCommand.cs&p1=trunk/irc/TechBot/TechBot.Library/HresultCommand.cs&r1=31130&r2=33344&rev=33344&view=diff

Copied: trunk/irc/TechBot/TechBot.Library/Commands/NtStatusCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/NtStatusCommand.cs)
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/NtStatusCommand.cs?p2=trunk/irc/TechBot/TechBot.Library/Commands/NtStatusCommand.cs&p1=trunk/irc/TechBot/TechBot.Library/NtStatusCommand.cs&r1=31130&r2=33344&rev=33344&view=diff

Copied: trunk/irc/TechBot/TechBot.Library/Commands/ReactOSBugUrl.cs (from r31130, trunk/irc/TechBot/TechBot.Library/ReactOSBugUrl.cs)
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/ReactOSBugUrl.cs?p2=trunk/irc/TechBot/TechBot.Library/Commands/ReactOSBugUrl.cs&p1=trunk/irc/TechBot/TechBot.Library/ReactOSBugUrl.cs&r1=31130&r2=33344&rev=33344&view=diff

Copied: trunk/irc/TechBot/TechBot.Library/Commands/SambaBugUrl.cs (from r31130, trunk/irc/TechBot/TechBot.Library/SambaBugUrl.cs)
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/SambaBugUrl.cs?p2=trunk/irc/TechBot/TechBot.Library/Commands/SambaBugUrl.cs&p1=trunk/irc/TechBot/TechBot.Library/SambaBugUrl.cs&r1=31130&r2=33344&rev=33344&view=diff

Copied: trunk/irc/TechBot/TechBot.Library/Commands/SvnCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/SvnCommand.cs)
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/SvnCommand.cs?p2=trunk/irc/TechBot/TechBot.Library/Commands/SvnCommand.cs&p1=trunk/irc/TechBot/TechBot.Library/SvnCommand.cs&r1=31130&r2=33344&rev=33344&view=diff

Copied: trunk/irc/TechBot/TechBot.Library/Commands/WineBugUrl.cs (from r31130, trunk/irc/TechBot/TechBot.Library/WineBugUrl.cs)
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/WineBugUrl.cs?p2=trunk/irc/TechBot/TechBot.Library/Commands/WineBugUrl.cs&p1=trunk/irc/TechBot/TechBot.Library/WineBugUrl.cs&r1=31130&r2=33344&rev=33344&view=diff

Copied: trunk/irc/TechBot/TechBot.Library/Commands/WinerrorCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/WinerrorCommand.cs)
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/WinerrorCommand.cs?p2=trunk/irc/TechBot/TechBot.Library/Commands/WinerrorCommand.cs&p1=trunk/irc/TechBot/TechBot.Library/WinerrorCommand.cs&r1=31130&r2=33344&rev=33344&view=diff

Copied: trunk/irc/TechBot/TechBot.Library/Commands/WmCommand.cs (from r31130, trunk/irc/TechBot/TechBot.Library/WmCommand.cs)
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Commands/WmCommand.cs?p2=trunk/irc/TechBot/TechBot.Library/Commands/WmCommand.cs&p1=trunk/irc/TechBot/TechBot.Library/WmCommand.cs&r1=31130&r2=33344&rev=33344&view=diff

Removed: trunk/irc/TechBot/TechBot.Library/ErrorCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/ErrorCommand.cs?rev=33343&view=auto

Added: trunk/irc/TechBot/TechBot.Library/Factory/CommandBuilder.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Factory/CommandBuilder.cs?rev=33344&view=auto

Added: trunk/irc/TechBot/TechBot.Library/Factory/CommandFactory.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/Factory/CommandFactory.cs?rev=33344&view=auto

Removed: trunk/irc/TechBot/TechBot.Library/HelpCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/HelpCommand.cs?rev=33343&view=auto

Removed: trunk/irc/TechBot/TechBot.Library/HresultCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/HresultCommand.cs?rev=33343&view=auto

Removed: trunk/irc/TechBot/TechBot.Library/IrcService.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/IrcService.cs?rev=33343&view=auto

Modified: trunk/irc/TechBot/TechBot.Library/MessageContext.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/MessageContext.cs?rev=33344&r1=33343&r2=33344&view=diff

Removed: trunk/irc/TechBot/TechBot.Library/NtStatusCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/NtStatusCommand.cs?rev=33343&view=auto

Added: trunk/irc/TechBot/TechBot.Library/ParametersParser.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/ParametersParser.cs?rev=33344&view=auto

Removed: trunk/irc/TechBot/TechBot.Library/ReactOSBugUrl.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/ReactOSBugUrl.cs?rev=33343&view=auto

Removed: trunk/irc/TechBot/TechBot.Library/SambaBugUrl.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/SambaBugUrl.cs?rev=33343&view=auto

Modified: trunk/irc/TechBot/TechBot.Library/ServiceOutput.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/ServiceOutput.cs?rev=33344&r1=33343&r2=33344&view=diff

Removed: trunk/irc/TechBot/TechBot.Library/SvnCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/SvnCommand.cs?rev=33343&view=auto

Modified: trunk/irc/TechBot/TechBot.Library/TechBot.Library.csproj
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/TechBot.Library.csproj?rev=33344&r1=33343&r2=33344&view=diff

Copied: trunk/irc/TechBot/TechBot.Library/TechBotIrcService.cs (from r31130, trunk/irc/TechBot/TechBot.Library/IrcService.cs)
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/TechBotIrcService.cs?p2=trunk/irc/TechBot/TechBot.Library/TechBotIrcService.cs&p1=trunk/irc/TechBot/TechBot.Library/IrcService.cs&r1=31130&r2=33344&rev=33344&view=diff

Modified: trunk/irc/TechBot/TechBot.Library/TechBotService.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/TechBotService.cs?rev=33344&r1=33343&r2=33344&view=diff

Removed: trunk/irc/TechBot/TechBot.Library/WineBugUrl.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/WineBugUrl.cs?rev=33343&view=auto

Removed: trunk/irc/TechBot/TechBot.Library/WinerrorCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/WinerrorCommand.cs?rev=33343&view=auto

Removed: trunk/irc/TechBot/TechBot.Library/WmCommand.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.Library/WmCommand.cs?rev=33343&view=auto

Removed: trunk/irc/TechBot/TechBot.cmbx
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot.cmbx?rev=33343&view=auto

Added: trunk/irc/TechBot/TechBot/ProjectInstaller.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot/ProjectInstaller.cs?rev=33344&view=auto

Modified: trunk/irc/TechBot/TechBot/ServiceThread.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot/ServiceThread.cs?rev=33344&r1=33343&r2=33344&view=diff

Modified: trunk/irc/TechBot/TechBot/TechBot.csproj
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot/TechBot.csproj?rev=33344&r1=33343&r2=33344&view=diff

Modified: trunk/irc/TechBot/TechBot/TechBotService.cs
URL: http://svn.reactos.org/svn/reactos/trunk/irc/TechBot/TechBot/TechBotService.cs?rev=33344&r1=33343&r2=33344&view=diff



More information about the Ros-diffs mailing list