[ros-diffs] [cfinck] 33382: Revert r33366 for regedit and compile it as Unicode with ANSI command line parsing again.. :-/ Changing everything internally to TCHAR would be like rewriting the app, because regedit even hardcodes string sizes in bytes and then memcmp's them... (see regproc.c:234) Compiling it ANSI-only also doesn't work, because the API's for ACL stuff are Unicode-only.

cfinck at svn.reactos.org cfinck at svn.reactos.org
Thu May 8 21:19:22 CEST 2008


Author: cfinck
Date: Thu May  8 14:19:22 2008
New Revision: 33382

URL: http://svn.reactos.org/svn/reactos?rev=33382&view=rev
Log:
Revert r33366 for regedit and compile it as Unicode with ANSI command line parsing again.. :-/

Changing everything internally to TCHAR would be like rewriting the app, because regedit even hardcodes string sizes in bytes and then memcmp's them... (see regproc.c:234)
Compiling it ANSI-only also doesn't work, because the API's for ACL stuff are Unicode-only.

Modified:
    trunk/reactos/base/applications/regedit/regedit.rbuild

Modified: trunk/reactos/base/applications/regedit/regedit.rbuild
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/regedit.rbuild?rev=33382&r1=33381&r2=33382&view=diff
==============================================================================
--- trunk/reactos/base/applications/regedit/regedit.rbuild [iso-8859-1] (original)
+++ trunk/reactos/base/applications/regedit/regedit.rbuild [iso-8859-1] Thu May  8 14:19:22 2008
@@ -1,8 +1,10 @@
 <?xml version="1.0"?>
 <!DOCTYPE group SYSTEM "../../../tools/rbuild/project.dtd">
 <group xmlns:xi="http://www.w3.org/2001/XInclude">
-<module name="regedit" type="win32gui" installname="regedit.exe" unicode="yes">
+<module name="regedit" type="win32gui" installname="regedit.exe">
 	<include base="regedit">.</include>
+	<define name="UNICODE" />
+	<define name="_UNICODE" />
 	<define name="_WIN32_IE">0x0501</define>
 	<define name="_WIN32_WINNT">0x0600</define>
 	<library>uuid</library>



More information about the Ros-diffs mailing list