[ros-diffs] [janderwald] 33400: - when menu position cannot be found insert new item at the end - reduces winetest failures from 1550 to 1250 - behaviour verified on Windows Vista

janderwald at svn.reactos.org janderwald at svn.reactos.org
Fri May 9 20:11:40 CEST 2008


Author: janderwald
Date: Fri May  9 13:11:40 2008
New Revision: 33400

URL: http://svn.reactos.org/svn/reactos?rev=33400&view=rev
Log:
- when menu position cannot be found insert new item at the end
- reduces winetest failures from 1550 to 1250
- behaviour verified on Windows Vista

Modified:
    trunk/reactos/subsystems/win32/win32k/ntuser/menu.c

Modified: trunk/reactos/subsystems/win32/win32k/ntuser/menu.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ntuser/menu.c?rev=33400&r1=33399&r2=33400&view=diff
==============================================================================
--- trunk/reactos/subsystems/win32/win32k/ntuser/menu.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/win32/win32k/ntuser/menu.c [iso-8859-1] Fri May  9 13:11:40 2008
@@ -953,8 +953,9 @@
    }
    if (SubMenu == NULL)
    {
-       SetLastWin32Error(ERROR_INVALID_PARAMETER);
-       return FALSE;
+       /* default to last position of menu */
+      SubMenu = MenuObject;
+      pos = MenuObject->MenuInfo.MenuItemCount;
    }
 
 



More information about the Ros-diffs mailing list