[ros-diffs] [fireball] 33521: Stefan Ginsberg <stefan__100__ at hotmail.com> - Spelling fixes. - Remove deprecated and unused HalReleaseDisplayOwnership prototype. - Fix handle leak in NtCreateProfile. - Don't miss an OBTRACE debug print in ObpCloseHandle in STATUS_SUCCESS case.

[fireball at svn.reactos.org]

Author: fireball
Date: Wed May 14 15:59:43 2008
New Revision: 33521

URL: http://svn.reactos.org/svn/reactos?rev=33521&view=rev
Log:
Stefan Ginsberg <stefan__100__ at hotmail.com>
- Spelling fixes.
- Remove deprecated and unused HalReleaseDisplayOwnership prototype.
- Fix handle leak in NtCreateProfile.
- Don't miss an OBTRACE debug print in ObpCloseHandle in STATUS_SUCCESS case.

Modified:
    trunk/reactos/ntoskrnl/config/cmsysini.c
    trunk/reactos/ntoskrnl/ex/i386/ioport.S
    trunk/reactos/ntoskrnl/ex/profile.c   (contents, props changed)
    trunk/reactos/ntoskrnl/ex/shutdown.c
    trunk/reactos/ntoskrnl/io/iomgr/driver.c   (contents, props changed)
    trunk/reactos/ntoskrnl/ob/obhandle.c
    trunk/reactos/ntoskrnl/ob/oblink.c

Modified: trunk/reactos/ntoskrnl/config/cmsysini.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmsysini.c?rev=33521&r1=33520&r2=33521&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/config/cmsysini.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/config/cmsysini.c [iso-8859-1] Wed May 14 15:59:43 2008
@@ -1046,7 +1046,7 @@
         RtlAppendStringToString((PSTRING)&RegName, (PSTRING)&TempName);
     }
     
-    /* Now Add tge rest if the file name */
+    /* Now add the rest of the file name */
     RtlInitUnicodeString(&TempName, CmpMachineHiveList[i].Name);
     FileName.Length = FileStart;
     RtlAppendStringToString((PSTRING)&FileName, (PSTRING)&TempName);
@@ -1062,7 +1062,7 @@
                                      &CmpMachineHiveList[i].Allocate,
                                      0);
         if (!(NT_SUCCESS(Status)) ||
-            (!(CmHive->FileHandles[HFILE_TYPE_LOG]) && !(CmpMiniNTBoot))) // hak
+            (!(CmHive->FileHandles[HFILE_TYPE_LOG]) && !(CmpMiniNTBoot))) // HACK
         {
             /* We failed or couldn't get a log file, raise a hard error */
             ErrorParameters = &FileName;

Modified: trunk/reactos/ntoskrnl/ex/i386/ioport.S
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/i386/ioport.S?rev=33521&r1=33520&r2=33521&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/ex/i386/ioport.S [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ex/i386/ioport.S [iso-8859-1] Wed May 14 15:59:43 2008
@@ -167,7 +167,7 @@
     /* Flush posted write buffers */
     lock or [esp+4], ecx
 
-    /* Restole volatiles and return */
+    /* Restore volatiles and return */
     mov edi, edx
     mov esi, eax
     ret 12
@@ -189,7 +189,7 @@
     /* Flush posted write buffers */
     lock or [esp+4], ecx
 
-    /* Restole volatiles and return */
+    /* Restore volatiles and return */
     mov edi, edx
     mov esi, eax
     ret 12
@@ -211,7 +211,7 @@
     /* Flush posted write buffers */
     lock or [esp+4], ecx
 
-    /* Restole volatiles and return */
+    /* Restore volatiles and return */
     mov edi, edx
     mov esi, eax
     ret 12

Modified: trunk/reactos/ntoskrnl/ex/profile.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/profile.c?rev=33521&r1=33520&r2=33521&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/ex/profile.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ex/profile.c [iso-8859-1] Wed May 14 15:59:43 2008
@@ -216,7 +216,14 @@
                             0,
                             sizeof(EPROFILE) + sizeof(KPROFILE),
                             (PVOID*)&Profile);
-    if (!NT_SUCCESS(Status)) return(Status);
+    if (!NT_SUCCESS(Status))
+    {
+        /* Dereference the process object if it was specified */
+        if (Process) ObDereferenceObject(Process);
+
+        /* Return Status */
+        return Status;
+    }
 
     /* Initialize it */
     Profile->RangeBase = RangeBase;

Propchange: trunk/reactos/ntoskrnl/ex/profile.c
------------------------------------------------------------------------------
--- svn:needs-lock (original)
+++ svn:needs-lock (removed)
@@ -1,1 +1,0 @@
-*

Modified: trunk/reactos/ntoskrnl/ex/shutdown.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/shutdown.c?rev=33521&r1=33520&r2=33521&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/ex/shutdown.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ex/shutdown.c [iso-8859-1] Wed May 14 15:59:43 2008
@@ -13,14 +13,6 @@
 #include <internal/debug.h>
 
 /* FUNCTIONS *****************************************************************/
-
-/* ROS Internal. Please deprecate */
-NTHALAPI
-VOID
-NTAPI
-HalReleaseDisplayOwnership(
-    VOID
-);
 
 VOID STDCALL
 KiHaltProcessorDpcRoutine(IN PKDPC Dpc,

Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/driver.c?rev=33521&r1=33520&r2=33521&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/driver.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/driver.c [iso-8859-1] Wed May 14 15:59:43 2008
@@ -1379,7 +1379,7 @@
 NTAPI
 IoDeleteDriver(IN PDRIVER_OBJECT DriverObject)
 {
-    /* Simply derefence the Object */
+    /* Simply dereference the Object */
     ObDereferenceObject(DriverObject);
 }
 

Propchange: trunk/reactos/ntoskrnl/io/iomgr/driver.c
------------------------------------------------------------------------------
--- svn:needs-lock (original)
+++ svn:needs-lock (removed)
@@ -1,1 +1,0 @@
-*

Modified: trunk/reactos/ntoskrnl/ob/obhandle.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obhandle.c?rev=33521&r1=33520&r2=33521&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/ob/obhandle.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ob/obhandle.c [iso-8859-1] Wed May 14 15:59:43 2008
@@ -1048,7 +1048,7 @@
             ObjectHeader->HandleCount,
             ObjectHeader->PointerCount);
 
-    /* Lock the object type */
+    /* Lock the object */
     ObpAcquireObjectLock(ObjectHeader);
 
     /* Charge quota and remove the creator info flag */
@@ -1714,7 +1714,7 @@
 
         /* Detach and return success */
         if (AttachedToProcess) KeUnstackDetachProcess(&ApcState);
-        return STATUS_SUCCESS;
+        Status = STATUS_SUCCESS;
     }
     else
     {

Modified: trunk/reactos/ntoskrnl/ob/oblink.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/oblink.c?rev=33521&r1=33520&r2=33521&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/ob/oblink.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ob/oblink.c [iso-8859-1] Wed May 14 15:59:43 2008
@@ -548,7 +548,7 @@
         }
         _SEH_END;
 
-        /* Unlock the object and reference the object */
+        /* Unlock and dereference the object */
         ObpReleaseObjectLock(OBJECT_TO_OBJECT_HEADER(SymlinkObject));
         ObDereferenceObject(SymlinkObject);
     }