[ros-diffs] [cfinck] 33788: Sync wininet with Wine. This fixes the Download! issue. As we implement some more functions in the network stack now, I could remove some hacks from the "wininet_ros.diff" file. Anyways, the following things still needed to be changed: - Pass a variable to WriteFile for receiving the number of bytes written. This parameter is not checked for NULL in ReactOS and Windows, when lpOverlapped is also NULL. I'll submit a patch about this to Wine as well. - Replace Unix poll() calls by equivalent select() calls - Bypass sock_get_error(), directly call WSAGetLastError() as we don't have to translate Unix socket errors. See issue #3197 for more details.

cfinck at svn.reactos.org cfinck at svn.reactos.org
Sat May 31 15:02:59 CEST 2008


Author: cfinck
Date: Sat May 31 08:02:59 2008
New Revision: 33788

URL: http://svn.reactos.org/svn/reactos?rev=33788&view=rev
Log:
Sync wininet with Wine. This fixes the Download! issue.

As we implement some more functions in the network stack now, I could remove some hacks from the "wininet_ros.diff" file.
Anyways, the following things still needed to be changed:
- Pass a variable to WriteFile for receiving the number of bytes written. This parameter is not checked for NULL in ReactOS and Windows, when lpOverlapped is also NULL.
  I'll submit a patch about this to Wine as well.
- Replace Unix poll() calls by equivalent select() calls
- Bypass sock_get_error(), directly call WSAGetLastError() as we don't have to translate Unix socket errors.

See issue #3197 for more details.

Added:
    trunk/reactos/dll/win32/wininet/wininet_Da.rc   (with props)
Modified:
    trunk/reactos/dll/win32/wininet/cookie.c
    trunk/reactos/dll/win32/wininet/ftp.c
    trunk/reactos/dll/win32/wininet/http.c
    trunk/reactos/dll/win32/wininet/internet.c
    trunk/reactos/dll/win32/wininet/internet.h
    trunk/reactos/dll/win32/wininet/netconnection.c
    trunk/reactos/dll/win32/wininet/rsrc.rc
    trunk/reactos/dll/win32/wininet/urlcache.c
    trunk/reactos/dll/win32/wininet/utility.c
    trunk/reactos/dll/win32/wininet/wininet.spec
    trunk/reactos/dll/win32/wininet/wininet_Ru.rc
    trunk/reactos/dll/win32/wininet/wininet_Si.rc
    trunk/reactos/dll/win32/wininet/wininet_Sv.rc
    trunk/reactos/dll/win32/wininet/wininet_ros.diff
    trunk/reactos/include/psdk/wininet.h

[This mail would be too long, it was shortened to contain the URLs only.]

Modified: trunk/reactos/dll/win32/wininet/cookie.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/cookie.c?rev=33788&r1=33787&r2=33788&view=diff

Modified: trunk/reactos/dll/win32/wininet/ftp.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/ftp.c?rev=33788&r1=33787&r2=33788&view=diff

Modified: trunk/reactos/dll/win32/wininet/http.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/http.c?rev=33788&r1=33787&r2=33788&view=diff

Modified: trunk/reactos/dll/win32/wininet/internet.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/internet.c?rev=33788&r1=33787&r2=33788&view=diff

Modified: trunk/reactos/dll/win32/wininet/internet.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/internet.h?rev=33788&r1=33787&r2=33788&view=diff

Modified: trunk/reactos/dll/win32/wininet/netconnection.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/netconnection.c?rev=33788&r1=33787&r2=33788&view=diff

Modified: trunk/reactos/dll/win32/wininet/rsrc.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/rsrc.rc?rev=33788&r1=33787&r2=33788&view=diff

Modified: trunk/reactos/dll/win32/wininet/urlcache.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/urlcache.c?rev=33788&r1=33787&r2=33788&view=diff

Modified: trunk/reactos/dll/win32/wininet/utility.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/utility.c?rev=33788&r1=33787&r2=33788&view=diff

Modified: trunk/reactos/dll/win32/wininet/wininet.spec
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/wininet.spec?rev=33788&r1=33787&r2=33788&view=diff

Added: trunk/reactos/dll/win32/wininet/wininet_Da.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/wininet_Da.rc?rev=33788&view=auto

Modified: trunk/reactos/dll/win32/wininet/wininet_Ru.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/wininet_Ru.rc?rev=33788&r1=33787&r2=33788&view=diff

Modified: trunk/reactos/dll/win32/wininet/wininet_Si.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/wininet_Si.rc?rev=33788&r1=33787&r2=33788&view=diff

Modified: trunk/reactos/dll/win32/wininet/wininet_Sv.rc
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/wininet_Sv.rc?rev=33788&r1=33787&r2=33788&view=diff

Modified: trunk/reactos/dll/win32/wininet/wininet_ros.diff
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/wininet_ros.diff?rev=33788&r1=33787&r2=33788&view=diff

Modified: trunk/reactos/include/psdk/wininet.h
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/wininet.h?rev=33788&r1=33787&r2=33788&view=diff



More information about the Ros-diffs mailing list