[ros-diffs] [cwittich] 36375: this hack wasn't supposed to be committed

cwittich at svn.reactos.org cwittich at svn.reactos.org
Sun Sep 21 15:05:49 CEST 2008


Author: cwittich
Date: Sun Sep 21 08:05:48 2008
New Revision: 36375

URL: http://svn.reactos.org/svn/reactos?rev=36375&view=rev
Log:
this hack wasn't supposed to be committed

Modified:
    trunk/reactos/dll/win32/advapi32/service/scm.c

Modified: trunk/reactos/dll/win32/advapi32/service/scm.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/service/scm.c?rev=36375&r1=36374&r2=36375&view=diff
==============================================================================
--- trunk/reactos/dll/win32/advapi32/service/scm.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/advapi32/service/scm.c [iso-8859-1] Sun Sep 21 08:05:48 2008
@@ -2124,29 +2124,6 @@
                            DWORD cbBufSize,
                            LPDWORD pcbBytesNeeded)
 {
-
-    SECURITY_DESCRIPTOR descriptor;
-    DWORD size;
-    BOOL succ;
-    ACL acl;
-
-    FIXME("%p %d %p %u %p - semi-stub\n", hService, dwSecurityInformation,
-          lpSecurityDescriptor, cbBufSize, pcbBytesNeeded);
-
-    if (dwSecurityInformation != DACL_SECURITY_INFORMATION)
-        FIXME("information %d not supported\n", dwSecurityInformation);
-
-    InitializeSecurityDescriptor(&descriptor, SECURITY_DESCRIPTOR_REVISION);
-
-    InitializeAcl(&acl, sizeof(ACL), ACL_REVISION);
-    SetSecurityDescriptorDacl(&descriptor, TRUE, &acl, TRUE);
-
-    size = cbBufSize;
-    succ = RtlMakeSelfRelativeSD(&descriptor, lpSecurityDescriptor, &size);
-    *pcbBytesNeeded = size;
-    return succ;
-
-#if 0
     DWORD dwError;
 
     TRACE("QueryServiceObjectSecurity(%p, %lu, %p)\n",
@@ -2178,7 +2155,6 @@
     }
 
     return TRUE;
-#endif
 }
 
 /**********************************************************************
@@ -2191,9 +2167,6 @@
                          SECURITY_INFORMATION dwSecurityInformation,
                          PSECURITY_DESCRIPTOR lpSecurityDescriptor)
 {
-	FIXME("%p %d %p\n", hService, dwSecurityInformation, lpSecurityDescriptor);
-    return TRUE;
-#if 0
     PSECURITY_DESCRIPTOR SelfRelativeSD = NULL;
     ULONG Length;
     NTSTATUS Status;
@@ -2253,7 +2226,6 @@
     }
 
     return TRUE;
-#endif
 }
 
 



More information about the Ros-diffs mailing list