[ros-diffs] [fireball] 36417: - The check for SystemHive being non-NULL is meaningless, because CmpInitializeHive is already checked for failure earlier, and in success case it returns a valid Hive. - Fix for Coverity error CID: 280

fireball at svn.reactos.org fireball at svn.reactos.org
Tue Sep 23 10:04:24 CEST 2008


Author: fireball
Date: Tue Sep 23 03:04:23 2008
New Revision: 36417

URL: http://svn.reactos.org/svn/reactos?rev=36417&view=rev
Log:
- The check for SystemHive being non-NULL is meaningless, because CmpInitializeHive is already checked for failure earlier, and in success case it returns a valid Hive.
- Fix for Coverity error CID: 280

Modified:
    trunk/reactos/ntoskrnl/config/cmsysini.c

Modified: trunk/reactos/ntoskrnl/config/cmsysini.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmsysini.c?rev=36417&r1=36416&r2=36417&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/config/cmsysini.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/config/cmsysini.c [iso-8859-1] Tue Sep 23 03:04:23 2008
@@ -775,7 +775,7 @@
     }
 
     /* Save the boot type */
-    if (SystemHive) CmpBootType = SystemHive->Hive.BaseBlock->BootType;
+    CmpBootType = SystemHive->Hive.BaseBlock->BootType;
 
     /* Are we in self-healing mode? */
     if (!CmSelfHeal)



More information about the Ros-diffs mailing list