[ros-diffs] [tkreuzer] 38959: go back to no debugging channels in freeldr
tkreuzer at svn.reactos.org
tkreuzer at svn.reactos.org
Tue Jan 20 00:02:14 CET 2009
- Previous message: [ros-diffs] [sginsberg] 38958: - Re-add allowwarnings="true" for wrc too - Re-add the wmc header fix too, accidentally reverted in previous commit
- Next message: [ros-diffs] [sginsberg] 38960: Fix the completely retarded implementation of KdComPortInUse. The original definition of this variable seems to have been based on the retarded type in the serial.sys source sample, which defines it as: extern PUCHAR *KdComPortInUse; This, somehow, works in MSVC, but gcc complains about the lack of import specifier (KdComPortInUse is exported by HAL). This was 'fixed' by adding the import specifier to ros. So instead of: PUCHAR *KdComPortInUse; We ended up with: NTHALAPI PUCHAR *KdComPortInUse; Which becomes 3 dereferences instead of 2, which is incorrect. This was 'fixed' by hacking the variable in HAL too. Use "extern PUCHAR NTHALAPI KdComPortInUse" to be compatible with both compilers, remove the HAL hacks, and fix the usage of the variable. Fixes the serial.sys crash when booted with _WINKD_ + kdcom from Windows 2003, as kdcom would (due to the HAL hack) set the internal 'pointer' to the port value, and serial would end up dereferencing the port address
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Author: tkreuzer
Date: Mon Jan 19 17:02:13 2009
New Revision: 38959
URL: http://svn.reactos.org/svn/reactos?rev=38959&view=rev
Log:
go back to no debugging channels in freeldr
Modified:
branches/ros-amd64-bringup/reactos/boot/freeldr/freeldr/debug.c
Modified: branches/ros-amd64-bringup/reactos/boot/freeldr/freeldr/debug.c
URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/boot/freeldr/freeldr/debug.c?rev=38959&r1=38958&r2=38959&view=diff
==============================================================================
--- branches/ros-amd64-bringup/reactos/boot/freeldr/freeldr/debug.c [iso-8859-1] (original)
+++ branches/ros-amd64-bringup/reactos/boot/freeldr/freeldr/debug.c [iso-8859-1] Mon Jan 19 17:02:13 2009
@@ -26,8 +26,8 @@
//#define DEBUG_ALL
//#define DEBUG_INIFILE
//#define DEBUG_REACTOS
-#define DEBUG_CUSTOM
-//#define DEBUG_NONE
+//#define DEBUG_CUSTOM
+#define DEBUG_NONE
#if defined (DEBUG_ALL)
ULONG DebugPrintMask = DPRINT_WARNING | DPRINT_MEMORY | DPRINT_FILESYSTEM |
- Previous message: [ros-diffs] [sginsberg] 38958: - Re-add allowwarnings="true" for wrc too - Re-add the wmc header fix too, accidentally reverted in previous commit
- Next message: [ros-diffs] [sginsberg] 38960: Fix the completely retarded implementation of KdComPortInUse. The original definition of this variable seems to have been based on the retarded type in the serial.sys source sample, which defines it as: extern PUCHAR *KdComPortInUse; This, somehow, works in MSVC, but gcc complains about the lack of import specifier (KdComPortInUse is exported by HAL). This was 'fixed' by adding the import specifier to ros. So instead of: PUCHAR *KdComPortInUse; We ended up with: NTHALAPI PUCHAR *KdComPortInUse; Which becomes 3 dereferences instead of 2, which is incorrect. This was 'fixed' by hacking the variable in HAL too. Use "extern PUCHAR NTHALAPI KdComPortInUse" to be compatible with both compilers, remove the HAL hacks, and fix the usage of the variable. Fixes the serial.sys crash when booted with _WINKD_ + kdcom from Windows 2003, as kdcom would (due to the HAL hack) set the internal 'pointer' to the port value, and serial would end up dereferencing the port address
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the Ros-diffs
mailing list