[ros-diffs] [sginsberg] 39001: - Partially revert 29656. NTOS calls HalQuerySystemInformation with HalFrameBufferCachingInformation, and disables PAT and MTRR if it returns success + TRUE. There is no reason this would be needed in ReactOS at the moment, so revert to old behaviour.

sginsberg at svn.reactos.org sginsberg at svn.reactos.org
Wed Jan 21 18:10:17 CET 2009


Author: sginsberg
Date: Wed Jan 21 11:10:16 2009
New Revision: 39001

URL: http://svn.reactos.org/svn/reactos?rev=39001&view=rev
Log:
- Partially revert 29656. NTOS calls HalQuerySystemInformation with HalFrameBufferCachingInformation, and disables PAT and MTRR if it returns success + TRUE. There is no reason this would be needed in ReactOS at the moment, so revert to old behaviour.

Modified:
    trunk/reactos/hal/halx86/generic/sysinfo.c

Modified: trunk/reactos/hal/halx86/generic/sysinfo.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/sysinfo.c?rev=39001&r1=39000&r2=39001&view=diff
==============================================================================
--- trunk/reactos/hal/halx86/generic/sysinfo.c [iso-8859-1] (original)
+++ trunk/reactos/hal/halx86/generic/sysinfo.c [iso-8859-1] Wed Jan 21 11:10:16 2009
@@ -35,20 +35,10 @@
 		REPORT_THIS_CASE(HalMapRegisterInformation);
 		REPORT_THIS_CASE(HalMcaLogInformation);
 		case HalFrameBufferCachingInformation:
-		if (BufferSize >= 1)
 		{
-			// The only caller that has been seen calling this function told
-			// us it expected a single byte back. We therefore guess it expects
-			// a BOOLEAN, and we dream up the value TRUE to (we think) tell it
-			// "Sure, the framebuffer is cached".
-			BOOLEAN ToReturn = TRUE;
-			DPRINT("%s: caller expects %u bytes (should be 1)\n", "HalFrameBufferCachingInformation", BufferSize);
-			ASSERT(sizeof(BOOLEAN) == 1);
-			*ReturnedLength = sizeof(BOOLEAN);
-			RtlCopyMemory(Buffer, &ToReturn, sizeof(BOOLEAN));
-			return STATUS_SUCCESS;
+            /* FIXME: TODO */
+            return STATUS_NOT_IMPLEMENTED;
 		}
-		break;
 		REPORT_THIS_CASE(HalDisplayBiosInformation);
 		REPORT_THIS_CASE(HalProcessorFeatureInformation);
 		REPORT_THIS_CASE(HalNumaTopologyInterface);



More information about the Ros-diffs mailing list