[ros-diffs] [sginsberg] 41837: - Fix a serious bug in KiDispatchException; DbgkForwardException got called with the SecondChance parameter set to FALSE when forwarding second chance exceptions to user mode debuggers! This bug, introduced in revision 23802, made second chance exceptions appear as first chance to user mode debuggers (meaning unhandled exceptions wouldn't get caught). Bug exposed by the ntdll winetest.

sginsberg at svn.reactos.org sginsberg at svn.reactos.org
Fri Jul 10 03:06:10 CEST 2009


Author: sginsberg
Date: Fri Jul 10 05:06:09 2009
New Revision: 41837

URL: http://svn.reactos.org/svn/reactos?rev=41837&view=rev
Log:
- Fix a serious bug in KiDispatchException; DbgkForwardException got called with the SecondChance parameter set to FALSE when forwarding second chance exceptions to user mode debuggers! This bug, introduced in revision 23802, made second chance exceptions appear as first chance to user mode debuggers (meaning unhandled exceptions wouldn't get caught). Bug exposed by the ntdll winetest.

Modified:
    trunk/reactos/ntoskrnl/ke/i386/exp.c

Modified: trunk/reactos/ntoskrnl/ke/i386/exp.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/exp.c?rev=41837&r1=41836&r2=41837&view=diff
==============================================================================
--- trunk/reactos/ntoskrnl/ke/i386/exp.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/ke/i386/exp.c [iso-8859-1] Fri Jul 10 05:06:09 2009
@@ -1029,7 +1029,7 @@
         }
 
         /* Try second chance */
-        if (DbgkForwardException(ExceptionRecord, TRUE, FALSE))
+        if (DbgkForwardException(ExceptionRecord, TRUE, TRUE))
         {
             /* Handled, get out */
             goto Exit;



More information about the Ros-diffs mailing list