[ros-diffs] [fireball] 42059: - Bring atan2 implementation from crt. Please excuse me for this hack, but gdi32 can't link to msvcrt, and ntdll doesn't export atan2. Static linkage to crt doesn't work either. - Remove advapi32 from the list of included DLLs, gdi32 must NOT link to advapi32, otherwise a circular dependency happens. - Remove ASSERT macro definition. - gdi32 builds without any errors or warnings.

[fireball at svn.reactos.org]

Author: fireball
Date: Sat Jul 18 20:53:05 2009
New Revision: 42059

URL: http://svn.reactos.org/svn/reactos?rev=42059&view=rev
Log:
- Bring atan2 implementation from crt. Please excuse me for this hack, but gdi32 can't link to msvcrt, and ntdll doesn't export atan2. Static linkage to crt doesn't work either.
- Remove advapi32 from the list of included DLLs, gdi32 must NOT link to advapi32, otherwise a circular dependency happens.
- Remove ASSERT macro definition.
- gdi32 builds without any errors or warnings.

Added:
    branches/arwinss/reactos/dll/win32/gdi32/atan2.c
      - copied unchanged from r42002, branches/arwinss/reactos/lib/sdk/crt/math/i386/atan2.c
Modified:
    branches/arwinss/reactos/dll/win32/gdi32/gdi32.rbuild
    branches/arwinss/reactos/dll/win32/gdi32/gdi_private.h

Modified: branches/arwinss/reactos/dll/win32/gdi32/gdi32.rbuild
URL: http://svn.reactos.org/svn/reactos/branches/arwinss/reactos/dll/win32/gdi32/gdi32.rbuild?rev=42059&r1=42058&r2=42059&view=diff
==============================================================================
--- branches/arwinss/reactos/dll/win32/gdi32/gdi32.rbuild [iso-8859-1] (original)
+++ branches/arwinss/reactos/dll/win32/gdi32/gdi32.rbuild [iso-8859-1] Sat Jul 18 20:53:05 2009
@@ -12,11 +12,11 @@
 	<library>ntdll</library>
 	<library>user32</library>
 	<library>kernel32</library>
-	<library>advapi32</library>
 	<library>win32ksys</library>
 	<library>pseh</library>
 	<library>dxguid</library>
 
+	<file>atan2.c</file>
 	<file>bidi.c</file>
 	<file>bitblt.c</file>
 	<file>bitmap.c</file>

Modified: branches/arwinss/reactos/dll/win32/gdi32/gdi_private.h
URL: http://svn.reactos.org/svn/reactos/branches/arwinss/reactos/dll/win32/gdi32/gdi_private.h?rev=42059&r1=42058&r2=42059&view=diff
==============================================================================
--- branches/arwinss/reactos/dll/win32/gdi32/gdi_private.h [iso-8859-1] (original)
+++ branches/arwinss/reactos/dll/win32/gdi32/gdi_private.h [iso-8859-1] Sat Jul 18 20:53:05 2009
@@ -531,8 +531,4 @@
 #endif
 #define assert(x) if (!(x)) {RtlAssert("#x",__FILE__,__LINE__, ""); }
 
-#ifndef ASSERT
-#define ASSERT(x) if (!(x)) {RtlAssert("#x",__FILE__,__LINE__, ""); }
-#endif
-
 #endif /* __WINE_GDI_PRIVATE_H */