[ros-diffs] [fireball] 41415: - Fix NULL pointer access in an error branch inside hub_clear_port_feature_completion(). Thanks to Christoph for testing.

fireball at svn.reactos.org fireball at svn.reactos.org
Mon Jun 15 15:30:51 CEST 2009


Author: fireball
Date: Mon Jun 15 17:30:50 2009
New Revision: 41415

URL: http://svn.reactos.org/svn/reactos?rev=41415&view=rev
Log:
- Fix NULL pointer access in an error branch inside hub_clear_port_feature_completion(). Thanks to Christoph for testing.

Modified:
    trunk/reactos/drivers/usb/nt4compat/usbdriver/hub.c

Modified: trunk/reactos/drivers/usb/nt4compat/usbdriver/hub.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/nt4compat/usbdriver/hub.c?rev=41415&r1=41414&r2=41415&view=diff
==============================================================================
--- trunk/reactos/drivers/usb/nt4compat/usbdriver/hub.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/usb/nt4compat/usbdriver/hub.c [iso-8859-1] Mon Jun 15 17:30:50 2009
@@ -762,10 +762,15 @@
                 //
                 // do not think the device is workable, no requests to it any more.
                 // including the int polling
-                //
-                // usb_free_mem( purb );
-                //
-                goto LBL_SCAN_PORT_STAT;
+
+                if (purb)
+                    usb_free_mem(purb);
+
+                if (port_idx)
+                    hub_check_reset_port_status(pdev, port_idx);
+
+                //reinitialize the int request, here to reduce some uncertainty of concurrency
+                hub_start_int_request(pdev);
             }
         }
         return;



More information about the Ros-diffs mailing list